Skip to content

Conversation

@IlyasDevelopment
Copy link
Contributor

@IlyasDevelopment IlyasDevelopment commented Nov 12, 2024

Change Summary

  • Added Pydantic schemas for MySQL connection
  • Added Pydantic schemas for MySQL source parameters and target parameters
  • Added unit tests for creating & updating MySQL connection and target
  • Updated README to include references to MySQL

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@IlyasDevelopment IlyasDevelopment self-assigned this Nov 12, 2024
@codecov
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.52%. Comparing base (9a03779) to head (e843320).
Report is 78 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #126      +/-   ##
===========================================
+ Coverage    87.39%   87.52%   +0.12%     
===========================================
  Files          142      143       +1     
  Lines         3308     3342      +34     
  Branches       251      251              
===========================================
+ Hits          2891     2925      +34     
  Misses         355      355              
  Partials        62       62              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IlyasDevelopment IlyasDevelopment merged commit af13e94 into develop Nov 13, 2024
@IlyasDevelopment IlyasDevelopment deleted the feature/DOP-19902 branch November 13, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants