Skip to content

Conversation

@IlyasDevelopment
Copy link
Contributor

@IlyasDevelopment IlyasDevelopment commented Nov 7, 2024

Change Summary

Previously, the Queue name field was unique among all groups. Now it is made unique within group_id. For this purpose, an additional read-only field slug is added, which is generated as $group_id-$name. We use this field as the name of the queue in RabbitMQ.

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@IlyasDevelopment IlyasDevelopment self-assigned this Nov 7, 2024
@codecov
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.66%. Comparing base (cd6386a) to head (aa89ae2).
Report is 83 commits behind head on develop.

Files with missing lines Patch % Lines
syncmaster/db/repositories/queue.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #119      +/-   ##
===========================================
+ Coverage    87.63%   87.66%   +0.02%     
===========================================
  Files          130      130              
  Lines         3090     3096       +6     
  Branches       241      241              
===========================================
+ Hits          2708     2714       +6     
  Misses         324      324              
  Partials        58       58              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IlyasDevelopment IlyasDevelopment marked this pull request as ready for review November 7, 2024 19:27
@IlyasDevelopment IlyasDevelopment merged commit fda0ed7 into develop Nov 8, 2024
@IlyasDevelopment IlyasDevelopment deleted the feature/DOP-19793 branch November 8, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants