Skip to content

feat: Use pm-implicit with Cuda12.x #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chezou wants to merge 2 commits into
base: main
Choose a base branch
from
+53 −5
Open

feat: Use pm-implicit with Cuda12.x #298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d08ef45
feat: Use pm-implicit with Cuda12.x
chezou Nov 24, 2025
59a82c9
Fix implicit BPR test with GPU
chezou Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 47 additions & 1 deletion poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,9 @@ scipy = [
{version = ">=1.14.1, <2.0.0", python = ">=3.10"} # scipy >=1.14.1 fails to install on Python 3.9
]
tqdm = "^4.27.0"
implicit = "^0.7.1"
implicit = {version = "^0.7.1", python = "<3.10"}
# implicit 0.7.2 wheel is built with Cuda 11, while other packages (like cupy-cuda12x) use Cuda 12.
pm-implicit = {version = "^0.7.3", python = ">=3.10"}
attrs = ">=19.1.0,<24.0.0"
typeguard = "^4.1.0"
pydantic = "^2.8.2"
Expand Down
6 changes: 3 additions & 3 deletions tests/models/test_implicit_bpr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,9 @@ def dataset(self) -> Dataset:
),
pd.DataFrame(
{
Columns.User: [10, 10, 20, 20],
Columns.Item: [17, 15, 17, 15],
Columns.Rank: [1, 2, 1, 2],
Columns.User: [20, 20],
Columns.Item: [17, 15],
Columns.Rank: [1, 2],
}
),
),
Expand Down