-
Notifications
You must be signed in to change notification settings - Fork 50
Updated lock dependancies #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #293 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 45 79 +34
Lines 2242 5365 +3123
===========================================
+ Hits 2242 5365 +3123 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates dependency versions in the lock file and makes associated test adjustments to handle changes in test data expectations. While the title mentions updating lock dependencies, the changes primarily focus on test modifications and dependency configuration updates.
- Updated cupy-cuda12x and fastrlock dependencies to exclude macOS systems using platform markers
- Modified test expectations by reducing dataset sizes and using dynamic user/item extraction from expected results
- Fixed a PyTorch tensor indexing issue by adding CPU conversion to avoid dtype attribute errors
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Added macOS exclusion markers for CUDA dependencies and documentation |
| rectools/models/rank/rank_torch.py | Fixed tensor indexing bug by converting to numpy before CSR matrix access |
| tests/models/test_implicit_bpr.py | Reduced test dataset and made user array dynamic based on expected results |
| tests/models/nn/transformers/test_sasrec.py | Reduced test expectations and made target items dynamic |
| tests/models/nn/transformers/test_bert4rec.py | Reduced test datasets and made user arrays dynamic based on expected results |
Description
poetry.lockfilecupyextra on macOStorch.dtype object has no attribute 'kind'error inTorchRankerType of change
How Has This Been Tested?
Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.