Skip to content

Conversation

@feldlime
Copy link
Collaborator

@feldlime feldlime commented Jul 20, 2025

Description

  • Updated dependancy versions in the poetry.lock file
  • Removed problematic parts of flaky tests tests
  • Fixed installation issue with cupy extra on macOS
  • Fixed torch.dtype object has no attribute 'kind' error in TorchRanker

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Optimization

How Has This Been Tested?

Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.

  • Have you read the contribution guide?
  • Have you updated the relevant docstrings? We're using Numpy format, please double-check yourself
  • Does your change require any new tests?
  • Have you updated the changelog file?

@feldlime feldlime requested a review from Copilot July 20, 2025 09:26

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (9b3992e) to head (ce45033).
⚠️ Report is 122 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #293     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           45        79     +34     
  Lines         2242      5365   +3123     
===========================================
+ Hits          2242      5365   +3123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@feldlime feldlime requested a review from Copilot July 22, 2025 14:01
@feldlime feldlime marked this pull request as ready for review July 22, 2025 14:01
@feldlime feldlime requested a review from blondered July 22, 2025 14:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates dependency versions in the lock file and makes associated test adjustments to handle changes in test data expectations. While the title mentions updating lock dependencies, the changes primarily focus on test modifications and dependency configuration updates.

  • Updated cupy-cuda12x and fastrlock dependencies to exclude macOS systems using platform markers
  • Modified test expectations by reducing dataset sizes and using dynamic user/item extraction from expected results
  • Fixed a PyTorch tensor indexing issue by adding CPU conversion to avoid dtype attribute errors

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pyproject.toml Added macOS exclusion markers for CUDA dependencies and documentation
rectools/models/rank/rank_torch.py Fixed tensor indexing bug by converting to numpy before CSR matrix access
tests/models/test_implicit_bpr.py Reduced test dataset and made user array dynamic based on expected results
tests/models/nn/transformers/test_sasrec.py Reduced test expectations and made target items dynamic
tests/models/nn/transformers/test_bert4rec.py Reduced test datasets and made user arrays dynamic based on expected results

@feldlime feldlime merged commit e1532b4 into main Jul 24, 2025
12 checks passed
@feldlime feldlime deleted the feature/update_lock_dependancies branch July 24, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants