Skip to content

Fix negative sampler config #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blondered merged 1 commit into from
Apr 10, 2025
Merged

Fix negative sampler config #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions rectools/models/nn/transformers/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@ class TransformerModelConfig(ModelConfig):
item_net_constructor_kwargs: tp.Optional[InitKwargs] = None
pos_encoding_kwargs: tp.Optional[InitKwargs] = None
lightning_module_kwargs: tp.Optional[InitKwargs] = None
negative_sampler_kwargs: tp.Optional[InitKwargs] = None
similarity_module_kwargs: tp.Optional[InitKwargs] = None
backbone_kwargs: tp.Optional[InitKwargs] = None

Expand Down
1 change: 1 addition & 0 deletions tests/models/nn/transformers/test_bert4rec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -865,6 +865,7 @@ def initial_config(self) -> tp.Dict[str, tp.Any]:
"item_net_constructor_kwargs": None,
"pos_encoding_kwargs": None,
"lightning_module_kwargs": None,
"negative_sampler_kwargs": None,
"similarity_module_kwargs": None,
"backbone_kwargs": None,
}
Expand Down
1 change: 1 addition & 0 deletions tests/models/nn/transformers/test_sasrec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -973,6 +973,7 @@ def initial_config(self) -> tp.Dict[str, tp.Any]:
"item_net_constructor_kwargs": None,
"pos_encoding_kwargs": None,
"lightning_module_kwargs": None,
"negative_sampler_kwargs": None,
"similarity_module_kwargs": None,
"backbone_kwargs": None,
}
Expand Down