-
Notifications
You must be signed in to change notification settings - Fork 50
Support Python 3.13 #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python 3.13 #227
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 45 78 +33
Lines 2242 5274 +3032
===========================================
+ Hits 2242 5274 +3032 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1152e98 to
384dfcc
Compare
6e6d193 to
40e3b71
Compare
40e3b71 to
d37e414
Compare
23bfe8f to
2d5ccf3
Compare
|
@feldlime Applied all the feedback, and CI passed. PTAL |
Co-authored-by: Emiliy Feldman <[email protected]>
03cebe9 to
d27aeee
Compare
|
Now, PyTorch 2.6 is supported, while pytorch_lightning is not available yet. |
|
@feldlime @blondered I confirmed that Python 3.13 CI has passed with pytorch-lightning 2.5.1 and PyTorch 2.6 🎉 If there's no objection, can you review and approve it? |
|
@blondered Can you review the PR when you have a chance? All the review comments @feldlime raised were resolved, and we now support all possible optional packages, including pytorch-lightning. I'm tired of following CHANGELOG.md conflicts again and again. |
feldlime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chezou Thanks a lot for the updates, especially for adjusting versions of packages, and also for your patience. I'm super sorry for such a long response.
I added just one comment because I didn't understand the purpose of the fastrlock package here. After this, we're ready to merge this PR
|
@feldlime Thanks for the review! I added a comment and hope it helps :) |
feldlime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thank you for the explanation
|
@chezou thank you so much for all of your contributions. We really appreciate it. I'm sorry it took so long with this PR. |
Description
Support Python 3.13, including:
excluding:
Type of change
How Has This Been Tested?
Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.