fix: support russh-sftp 2.3 API#114
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea611792fd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if let Some(timeout_seconds) = timeout_seconds { | ||
| sftp_config.request_timeout_secs = timeout_seconds; | ||
| } | ||
| let sftp = SftpSession::new_with_config(channel.into_stream(), sftp_config).await?; |
There was a problem hiding this comment.
Bump the russh-sftp requirement with the new API
This call now requires the russh-sftp 2.3 API, but Cargo.toml still declares russh-sftp = "2.1.1" (Cargo.toml:21). In workspaces or downstream builds whose lockfile already contains russh-sftp 2.1.x, Cargo is allowed to keep that version, where SftpSession only has new/new_opts and no new_with_config, so updating this crate can fail to compile until the transitive dependency is manually updated. Please raise the dependency floor to the first version that provides new_with_config.
Useful? React with 👍 / 👎.
|
Addressed the dependency-floor issue by bumping Additional verification:
|
Summary
SftpSession::new_optscall withSftpSession::new_with_configrequest_timeout_secswhen providedrussh-sftpto 2.3.x from the currentrussh-sftp = "2.1.1"requirementTesting
cargo +1.95.0 checkcargo +1.95.0 fmt --check(passes; rustfmt warns that two configured import options are nightly-only)