Refactor: code quality, performance, and feature improvements #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add type aliases (RuleEntry, WildcardEntry) for complex tuple types - Add TypedDict for stats dictionaries in cleaner.py and pipeline.py - Add named constants (LRU_CACHE_SIZE) for better readability - Add Final type hints for all module-level constants - Add __all__ exports in scripts/__init__.py - Add comprehensive docstrings with examples for all public functions - Reorganize UNSUPPORTED_MODIFIERS by category with inline docs - Bump version to 1.3.0
- Use sys.intern() for domain strings (memory dedup, faster lookups) - Add EMPTY_FROZENSET constant to avoid repeated allocations - Add fast-path in should_prune_by_modifiers() for empty modifiers (~90% of calls) - Use walrus operator for early exit on empty lines - Use tuple form for startswith() calls (single call vs OR) - Restructure extract_abp_info() for early return on no modifiers
- New save_stats_json() function to export stats as JSON - JSON includes version, timestamp, execution time, and all statistics - Useful for CI/CD integration and monitoring
- Changed other_rules from list to set for O(1) duplicate checks during parse - Removed separate Phase 4 deduplication step (reduces memory usage) - Same output, lower peak memory, slightly faster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes improvements across three areas:
Features
--json-stats <path>flag for machine-readable statistics outputPerformance
other_rules(reduces memory)sys.intern()for domain stringsCode Quality