Skip to content

refactor(cloud): use cols to fix footer at the bottom #1851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sourishkrout merged 1 commit into from
Jan 9, 2026
Merged

refactor(cloud): use cols to fix footer at the bottom #1851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions cloud/app/components/blocks/navigation/footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,7 @@ import { cn } from "@/app/lib/utils";

export default function Footer() {
return (
<footer
className={cn(
"mt-auto w-full px-4 pt-4 pb-3 sm:px-6 md:px-12",
"landing-text",
)}
>
<footer className="mt-auto w-full px-4 pt-4 pb-3 sm:px-6 md:px-12">
<div className="mx-auto flex max-w-5xl flex-col-reverse items-center justify-between md:flex-row md:items-center">
<div className="mt-4 text-center text-sm sm:text-base md:mt-0 md:text-left font-handwriting">
<p>© 2025 Mirascope. All rights reserved.</p>
Expand Down
5 changes: 1 addition & 4 deletions cloud/app/components/blocks/navigation/header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,7 @@ export default function Header() {
<MirascopeLogo
size="small"
withText={true}
textClassName={cn(
"landing-text",
HEADER_STYLES.logoText(isSearchOpen),
)}
textClassName={cn(HEADER_STYLES.logoText(isSearchOpen))}
/>
</Link>
<DesktopNavigation isSearchOpen={isSearchOpen} />
Expand Down
18 changes: 10 additions & 8 deletions cloud/app/routes/__root.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,16 +64,18 @@ function RootComponent() {
<ThemeProvider>
<QueryClientProvider client={queryClient}>
<AuthProvider>
<Header />
<main className="grow">
{/* Content container with padding to account for fixed header */}
<div className="flex min-h-screen flex-col">
<Header />
<div className="mx-auto w-full max-w-7xl grow pt-(--header-height)">
<Outlet />
<main className="grow">
{/* Content container with padding to account for fixed header */}
<Outlet />
</main>
</div>
</main>
<Footer />
<TanStackRouterDevtools />
<Scripts />
<Footer />
<TanStackRouterDevtools />
<Scripts />
</div>
</AuthProvider>
</QueryClientProvider>
</ThemeProvider>
Expand Down