-
Notifications
You must be signed in to change notification settings - Fork 99
fix(ci): use clickhouse-client for multi-statement SQL init #1819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -211,11 +211,7 @@ jobs: | |
| run: bun install --frozen-lockfile | ||
|
|
||
| - name: Initialize ClickHouse | ||
| run: | | ||
| for script in docker/clickhouse/init/*.sql; do | ||
| echo "Running $script..." | ||
| curl -s "http://${CLICKHOUSE_USER}:${CLICKHOUSE_PASSWORD}@localhost:8123/" --data-binary @"$script" | ||
| done | ||
| run: bun run clickhouse:migrate | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This line is causing CI to fail because the new 'bun run clickhouse:migrate' command is trying to execute migration files that contain PostgreSQL-style syntax incompatible with ClickHouse. The migration files need to be updated to use proper ClickHouse syntax (replacing types like VARCHAR with String, etc.) before this command can work correctly. Spotted by Graphite Agent (based on CI logs) |
||
|
|
||
| - name: Run `vitest` with code coverage | ||
| run: bun run test:coverage | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is causing the CI to fail because it's using 'bun run clickhouse:migrate' which is likely not properly set up. Either the script is not defined in package.json, or the migrator.ts file and migrations directory with SQL files don't exist in the expected location. Ensure that the clickhouse:migrate script is defined in package.json, the migrator.ts file is properly implemented, and the SQL migration files have been moved from docker/clickhouse/init/ to clickhouse/migrations/.
Spotted by Graphite Agent (based on CI logs)

Is this helpful? React 👍 or 👎 to let us know.