fix: async call decorator compatibility with tenacity retry #1775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark async wrapper's __call__ attribute as async function so tenacity's is_coroutine_callable helper correctly detects it as an async callable. This enables tenacity's @Retry decorator to work properly with async llm.call decorated functions. Fixes Mirascope#989 Signed-off-by: majiayu000 <[email protected]>
willbakst
reviewed
Dec 30, 2025
| ) -> Awaitable[ | ||
|
|
||
| async def _async_call_impl( | ||
| current_context: Any, # noqa: ANN401 |
Collaborator
There was a problem hiding this comment.
Can we get a better type here than Any?
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1775 +/- ##
==========================================
- Coverage 99.99% 99.98% -0.01%
==========================================
Files 513 513
Lines 21398 21443 +45
==========================================
+ Hits 21397 21440 +43
- Misses 1 3 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issue
Fixes #989
Test Plan