[7.0] Share EventBus instances across different types where applicable #97
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#69 mentioned the following possible future enhancement:
Consider the following example:
The
BUS
fields currently refer to differentEventBus
instances, although they effectively do the same thing - regardless of whether you add a listener to the parent or the child, and regardless of whether you post theMyEventImpl
instance on the parent's bus or the child's.This PR makes the
CancellableEventBus.create(MyEventImpl.class);
call return the bus of the parent instead of creating a new instance, reducing memory usage by sharing the same instance across both classes.