Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat. Adding the motd management option from the site #11

Merged
merged 5 commits into from
Dec 26, 2019
Merged

feat. Adding the motd management option from the site #11

merged 5 commits into from
Dec 26, 2019

Conversation

nivcoo
Copy link
Member

@nivcoo nivcoo commented Dec 24, 2019

No description provided.

@Shyrogan
Copy link
Contributor

Il me semble que replace(String, String) remplace que le premier avec Java donc faudrait plutôt utiliser replaceAll(String, String)

@nivcoo
Copy link
Member Author

nivcoo commented Dec 25, 2019

C'est vrai mais j'etais parti dans l'optique ou la personne mets qu'un fois la variable je termine mon autre pull et je modif

@nivcoo
Copy link
Member Author

nivcoo commented Dec 25, 2019

Je viens de lire la javaDoc c'est pas le cas, le replace remplace toute les occurrences il y a le replaceFirst qui remplace que le premier

@Shyrogan
Copy link
Contributor

Je viens de lire la javaDoc c'est pas le cas, le replace remplace toute les occurrences il y a le replaceFirst qui remplace que le premier

J'étais pas sûr et effectivement pour un caractère replace fonctionne

@MaximeMichaud MaximeMichaud mentioned this pull request Dec 26, 2019
Closed
@Eywek Eywek merged commit ef89548 into MineWeb:master Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmarchaud vmarchaud vmarchaud approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nivcoo @Shyrogan @vmarchaud @Eywek