Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit Ping to be less frequent. #532

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Limit Ping to be less frequent. #532

merged 4 commits into from
Nov 25, 2024

Conversation

phillip-haydon
Copy link
Contributor

This changes the way Ping happens by:

  • Limiting ping to be once per session.
  • Failure to ping will re-attempt at intervals of 10/20/40/80/120 seconds before stopping.
  • Re-ping if data changes. This happens if the app sent true for rum and then changed to false, it would cause a re-ping to happens.

PanosNB
PanosNB previously approved these changes Nov 19, 2024
View reviewed changes
Copy link

@PanosNB PanosNB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Clear for pre release on our systems and monitor the situation

MattByers
MattByers approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@MattByers MattByers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@phillip-haydon phillip-haydon merged commit 5cedcbb into master Nov 25, 2024
2 checks passed
@phillip-haydon phillip-haydon deleted the ph/limit-ping branch November 25, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattByers MattByers MattByers approved these changes

@Hamish-taylor Hamish-taylor Awaiting requested review from Hamish-taylor

@PanosNB PanosNB Awaiting requested review from PanosNB

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phillip-haydon @PanosNB @MattByers