Changed the message of scriptError #251
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Olwiba
approved these changes
Jul 25, 2023
Contributor
Olwiba
left a comment
Olwiba
left a comment
There was a problem hiding this comment.
This change looks good, I can see where this would be useful
Contributor
|
This issues was resolved with more descriptive 'in-app' message. https://raygun.com/documentation/language-guides/javascript/crash-reporting/script-errors/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scriptError variable seems misleading given it only becomes the message if the stacktrace is empty. If this is the only cases that this happens, we should at least differentiate the message from the standard Script Error thrown by browsers.
Situations where the Stacktrace can be empty but not a script error: csnover/TraceKit#70