-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: #6 support environment variables #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me, I will leave an approval for someone else to get a second set of eyes :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops forgot to change Comment > Approve :)
Edit: Oh it needs @TheRealAgentK to approve too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
feat: #6 support environment variables
Description 📝
Type of change
Updates
config_props.dart
which loads common configuration parameters.environment.dart
which allows to override Environment variables for testing.config_props_test.dart
.symbols
andsourcemap
to use the config props class.Screenshots 📷
e.g. calling to
symbols list
with env variables:(
--verbose
prints the config params)Test plan 🧪
Tested manually and created unit test
Author to check 👓
Reviewer to check ✔️