Update setUserId of FbAppender to accept nullable argument (#151)

Mindera · Aug 10, 2021 · d4f0171 · d4f0171
1 parent 070dd0e
commit d4f0171
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/analytics-firebase/src/main/java/com/mindera/skeletoid/analytics/appenders/FbAppender.kt b/analytics-firebase/src/main/java/com/mindera/skeletoid/analytics/appenders/FbAppender.kt
@@ -72,7 +72,7 @@ class FbAppender : IAnalyticsAppender {
         firebaseAnalytics?.logEvent(FirebaseAnalytics.Event.SCREEN_VIEW, mapToBundle(parameters))
     }
 
-    override fun setUserId(userId: String) {
+    override fun setUserId(userId: String?) {
         if (firebaseAnalytics == null) {
             LOG.e(LOG_TAG, "setUserId failed: firebaseAnalytics is null")
             return

diff --git a/base/src/main/java/com/mindera/skeletoid/analytics/Analytics.kt b/base/src/main/java/com/mindera/skeletoid/analytics/Analytics.kt
@@ -115,7 +115,7 @@ object Analytics {
      *
      * @param userID ID of the user
      */
-    fun setUserID(userID: String) {
+    fun setUserID(userID: String?) {
         instance?.setUserID(userID)
     }
 

diff --git a/base/src/main/java/com/mindera/skeletoid/analytics/AnalyticsManager.kt b/base/src/main/java/com/mindera/skeletoid/analytics/AnalyticsManager.kt
@@ -92,7 +92,7 @@ class AnalyticsManager internal constructor() : IAnalyticsManager {
         }
     }
 
-    override fun setUserID(userID: String) {
+    override fun setUserID(userID: String?) {
         for (appender in analyticsAppenders.values) {
             appender.setUserId(userID)
         }

diff --git a/.../src/main/java/com/mindera/skeletoid/analytics/appenders/interfaces/IAnalyticsAppender.kt b/.../src/main/java/com/mindera/skeletoid/analytics/appenders/interfaces/IAnalyticsAppender.kt
@@ -63,7 +63,7 @@ interface IAnalyticsAppender {
      *
      * @param userId ID of the user
      */
-    fun setUserId(userId: String)
+    fun setUserId(userId: String?)
 
     /**
      * Sets a custom property of the user

diff --git a/base/src/main/java/com/mindera/skeletoid/analytics/interfaces/IAnalyticsManager.kt b/base/src/main/java/com/mindera/skeletoid/analytics/interfaces/IAnalyticsManager.kt
@@ -69,7 +69,7 @@ interface IAnalyticsManager {
      *
      * @param userID ID of the user
      */
-    fun setUserID(userID: String)
+    fun setUserID(userID: String?)
 
     /**
      * Sets a custom property of the user