MPA-77_get-events-by-policy #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcosteira79
reviewed
May 8, 2023
| @@ -11,6 +11,19 @@ class EventApiClient(engine: HttpClientEngine) : IEventApiClient { | |||
|
|
|||
| private val apiHttpClient = ApiHttpClient(engine) | |||
| private val httpClient = apiHttpClient.httpClient | |||
| override suspend fun getEventsByPolicy(userId: String, policyId: String): Result<List<EventDTO>> { | |||
rcosteira79
reviewed
May 8, 2023
| if (response.status == HttpStatusCode.OK) { | ||
| Result.success(response.body()) | ||
| } else { | ||
| Result.failure(Exception(response.status.description)) |
There was a problem hiding this comment.
Há algum tipo de documentação ou swagger que diga o tipo de excepções que podem ocorrer?
There was a problem hiding this comment.
Não, é por isso que decidimos criar uma exception com a mensagem que vem da API
rcosteira79
approved these changes
May 8, 2023
There was a problem hiding this comment.
Só um aparte na organização do projecto: evitem ter packages com nomes genéricos tipo "interfaces". Com o tempo, acabam por ficar cheios de ficheiros baseados no tipo de ficheiro (neste caso, interfaces), em vez de baseado no comportamento/propósito dos ficheiros. Por outras palavras, é mais fácil manter o código a longo prazo se os ficheiros que estão tightly coupled estiverem perto uns dos outros.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of getting events of an user filtered by a policy