MPA-90_refactor-kotlin-result-to-request-result #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-to-request-result
andresantos252
requested review from
beloso,
silvaric,
rcosteira79 and
JoaoRaimundo
rcosteira79
reviewed
May 8, 2023
| class EventRepository(private val apiClient: IEventApiClient) : IEventRepository { | ||
| override suspend fun getAllEventsForUser(userId: String): Result<List<EventDTO>> { | ||
| return apiClient.getAllEventsForUser(userId) | ||
| override suspend fun getAllEventsForUser(userId: String): RequestResult<List<EventDTO>> { |
There was a problem hiding this comment.
Vão ter camada de domínio no projeto? Se sim, não faz muito sentido um repositório, que é suposto devolver domain models, devolver um RequestResult. O domínio é agnóstico à origem dos dados.
There was a problem hiding this comment.
A ideia era facilitar a passagem de erros para as camadas que chamam os repo
rcosteira79
reviewed
May 8, 2023
| @@ -43,8 +49,8 @@ class EventRepository(private val apiClient: IEventApiClient) : IEventRepository | |||
| includesBreakfast: Boolean?, | |||
| city: String?, | |||
| project: ProjectDTO? | |||
| ): Result<Nothing?> { | |||
| ): RequestResult<Nothing?> { | |||
There was a problem hiding this comment.
Isto não te vai rebentar sempre que chamares o método? Se queres devolver "nada" usa Unit. O Nothing dá trigger a excepções se bem me lembro.
…A-90_refactor-kotlin-result-to-request-result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the return type of the repositories from Kotlin Result to RequestResult, which is equivalent to the former, and allows Swift code to access the Result value or error.