Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alfmob 33 implemented ci cd #7
base: main
Are you sure you want to change the base?
Alfmob 33 implemented ci cd #7
Changes from all commits
04555a8
f41ebe1
ecb4bd1
7d0b48a
cddcdd2
1fcfbb8
3f124da
fb9dd88
b42d324
6ec1c66
bddc731
d8428f1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no need to add the
.github
folder to the.xcodeproj
, neither thealfie.yml
fileThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the idea is that we can edit these files while working on the project in Xcode, instead of having to open another editor.
To your point, I think we might not need to add the whole folder and just add the relevant files.
IMO we just need to be careful that these files aren't added to the app target, but I don't see any problem in adding them to the project as references. In other projects I've worked on we even create a group without folder, and add file references to it for all these CI/tooling/setup/documentation files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a swiftlint fastlane action. I have mixed feelings about bundling
swiftlint
executable in the project, but I tend to prefer it being povided externally (e.g. via brew, SPM plugin, ...)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps use
run_tests
action (akascan
) ?https://docs.fastlane.tools/getting-started/ios/running-tests/
We can also set
SCAN_DESTINATION
and any other env var once which then gets passed automatically to each fastlane action. Take a look here for scan's parameters, for instance.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to store the
api_key
, as this action stores it on the environment for subsequent actions to use (such asupload_to_testflight
,match
, etc)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are incrementing the build number, but how is it updated after each build?
Shouldn't we get the last tag's value, extract the BN, then increment and set it on the Xcode project instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can and probably should store the Xcode project's path on an env var, which avoids duplication and possible errors.