-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New gossip_net backend using libp2p #3988
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: .circleci/config.yml .circleci/config.yml.jinja .gitattributes CODEOWNERS frontend/website/docs/developers/directory-structure.md frontend/website/docs/glossary.md src/app/cli/src/tests/coda_archive_node_test.ml src/app/cli/src/tests/coda_batch_payment_test.ml src/app/cli/src/tests/coda_bootstrap_test.ml src/app/cli/src/tests/coda_change_snark_worker_test.ml src/app/cli/src/tests/coda_delegation_test.ml src/app/cli/src/tests/coda_peers_test.ml src/app/cli/src/tests/coda_process.ml src/app/cli/src/tests/coda_processes.ml src/app/cli/src/tests/coda_receipt_chain_test.ml src/app/cli/src/tests/coda_restart_node_test.ml src/app/cli/src/tests/coda_restarts_and_txns_holy_grail.ml src/app/cli/src/tests/coda_shared_prefix_test.ml src/app/cli/src/tests/coda_transitive_peers_test.ml src/app/cli/src/tests/coda_txns_and_restart_non_producers.ml src/app/cli/src/tests/coda_worker.ml src/app/cli/src/tests/coda_worker_testnet.ml src/lib/coda_lib/coda_lib.ml src/lib/coda_lib/dune src/lib/consensus/proof_of_stake.ml src/lib/daemon_rpcs/types.ml src/lib/transition_frontier_controller/transition_frontier_controller.ml
deepthiskumar
approved these changes
Feb 7, 2020
bkase
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the revival of the tmp/cmr/net2 branch rebased onto develop.
Some important user-facing changes:
Some important internal changes:
Outstanding details:
opening a coda RPC stream) (Manage more malfeasance in libp2p #4098).
Current pubsub validation flow goes a bit against the libp2p grain, and it's not clear to me that the current behavior will survive this libp2p PR. There's an inline comment near the should_forward_message impl (Rework should_forward_message use in Gossip_net.Libp2p #4097).doneOther changes:
Future improvements: