Delay converting genesis ledgers #17789
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glyh
changed the title
glyh
force-pushed
the
lyh/remove-backing-control-for-genesis
branch
2 times, most recently
from
5337801 to
af4886b
Compare
glyh
changed the title
glyh
commented
Sep 17, 2025
| Mina_ledger.Ledger.Root.Config.( | ||
| equal_backing_type ledger_backing Converting_db) | ||
| then | ||
| Persistent_root.convert_instance_exn ~logger ~here:[%here] persistent_root ; |
Member
Author
There was a problem hiding this comment.
This is where we run the conversion.
glyh
changed the title
Member
Author
|
Actually, we might have a bug here. if downstream refer to the root and save it. lifting a stable root to converting root will create a new variable. I should've store the ref inside the root instead. Still, except for that this should be okay for a review. Will fix when I'm here tomorrow. |
Member
Sorry, I missed this part of the comment. |
Member
Author
|
I guess this is already done in your other PRs? If not, this need to be reworked because related code had been touched though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17747 and partially #17754
For epoch ledger parts would be done in another PR.