Use Proof_cache_tag.t in Ledger_proof.t #16469
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement structure as abstract in statement and proof. This would be useful to differentiate in proof as in wire types and a proof as a reference to cache.
This cleans up code. Sexp derivations were not used a lot, and json alternative exists for dumping to a text format. Some implications: * Output of sexp is not supported for dump_blocks * Sexp is not supported for precomputed blocks
Context: Derivations `compare`, `sexp` are not used in any meangful way. Derivation `yojson` isn't needed beyond Stable modules (it's used for logging and for precomputed blocks dumping). Problem: changing structure of `Transaction_snark.t` to use DB cache for proofs is complicated because `equal`, `compare`, `sexp` and `json` all need to be derived for the alternative representation. Running these methods would become potentially expensive by requiring DB reads, and hiding this complexity within such trivial methods is undesirable. Solution: remove unnecessary derivations. Leave `yojson` only for Stable module types.
Having the two types equal defeats the purpose of type separation.
Currently we store too much of data in the LRU cache
Accept/return state hash instead of `Root_data.Mimimal.t`
Remove `Stable.Latest.t = t` from interfaces. This is a preparation step for removing the equality in the implementation as well.
georgeee
force-pushed
the
georgeee/proof-cache-tag
branch
from
d79a1cd to
f42e546
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain your changes:
Explain how you tested your changes:
*
Checklist: