-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opinionated refactoring of #16415 #16467
Merged
dkijania
merged 46 commits into
dkijania/transaction_pool_tests
from
mrmr1993/transaction_pool_tests
Jan 16, 2025
Merged
Opinionated refactoring of #16415 #16467
dkijania
merged 46 commits into
dkijania/transaction_pool_tests
from
mrmr1993/transaction_pool_tests
Jan 16, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon #16415. The commits in this PR apply a series of transformations to make the code more readable and maintainable. Most notably:
Account_spec
is renamed toSimple_account
Account_spec.t array
pattern is encapsulated as a newSimple_ledger
moduleCommand_spec
is renamed toSimple_command
sender_info
struct instead of a full accountThe goal of this PR is to modify the original so that abstractions and naming guide the reader towards an understanding of mutability, the differences between the various arrays and 'spec' concepts, and more generally the mapping between the test code and the concepts in the rest of the code. The diff with compatible can be found here for reference.