Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stub methods for lagrange_commitments_whole_domain #16365

Closed
wants to merge 2 commits into from

Conversation

volhovm
Copy link
Member

@volhovm volhovm commented Nov 19, 2024

This PR introduced a function lagrange_commitments_whole_domain on the ocaml bindings side: #16272

It appears that this has to be mirrored on the o1js side for bindings to work well. Without this, the attempt to update mina to the newest compatible on o1js main results in npm run build:update-bindings complaining:

You can prevent the generation of dummy implementations with the commandline option '--disable genprim'
Missing primitives:
  caml_fp_srs_lagrange_commitments_whole_domain
  caml_fq_srs_lagrange_commitments_whole_domain

@volhovm volhovm requested a review from Trivo25 November 19, 2024 15:29
@volhovm
Copy link
Member Author

volhovm commented Nov 19, 2024

!ci-build-me

@volhovm
Copy link
Member Author

volhovm commented Feb 3, 2025

I assume this is no longer necessary since we have the lagrange_commitments_whole_domain in compatible for a while and everything works.

@volhovm volhovm closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant