-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resurrecting lookup PR: Fix lookup has_zero_entry bug #14725
Merged
dannywillems
merged 6 commits into
develop
from
volhovm/14674-resurrect-lookup-pr-chunk1
Dec 21, 2023
Merged
Resurrecting lookup PR: Fix lookup has_zero_entry bug #14725
dannywillems
merged 6 commits into
develop
from
volhovm/14674-resurrect-lookup-pr-chunk1
Dec 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
!ci-build-me |
6c5b2ac
to
8788d16
Compare
!ci-build-me |
OK, so it contains a bug that CI doesn't catch! My suspicion is that it's a test with an erroneous setup. Will look into it.
|
d188497
to
3fbf5c0
Compare
3fbf5c0
to
b7db98b
Compare
b7db98b
to
63c1aea
Compare
!ci-build-me |
I confirm the tests passing locally in addition to the CI. |
!ci-build-me |
!ci-build-me |
1 similar comment
!ci-build-me |
Note: #14637 moves to alcotest and will conflict with this PR. |
dannywillems
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating
proof-systems
to contain this bugfix:proof-systems
PR: Resurrecting lookup PR: Fix lookup has_zero_entry bug o1-labs/proof-systems#1567