Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resurrecting lookup PR: Fix lookup has_zero_entry bug #14725

Merged
merged 6 commits into from
Dec 21, 2023

Conversation

volhovm
Copy link
Member

@volhovm volhovm commented Dec 15, 2023

Updating proof-systems to contain this bugfix:

@volhovm
Copy link
Member Author

volhovm commented Dec 15, 2023

!ci-build-me

@volhovm
Copy link
Member Author

volhovm commented Dec 15, 2023

!ci-build-me

@volhovm volhovm changed the title Resurrecting lookup PR: Fix lookup has_zero_entry bug [DO NOT MERGE] Resurrecting lookup PR: Fix lookup has_zero_entry bug Dec 15, 2023
@volhovm
Copy link
Member Author

volhovm commented Dec 15, 2023

OK, so it contains a bug that CI doesn't catch! My suspicion is that it's a test with an erroneous setup. Will look into it.

======================================================================
TEST_MODULE at file "src/lib/pickles/wrap.ml", line 541, characters 4-358: lookup threw
(Failure
  "called `Result::unwrap()` on an `Err` value: ConstraintSystem(\"The table with id 0 must have an entry of all zeros\")").
  Raised at Base__Exn.protectx in file "src/exn.ml", line 71, characters 4-114
  Called from Ppx_inline_test_lib__Runtime.Module_context.with_ in file "runtime-lib/runtime.ml", line 165, characters 6-10
  Re-raised at Ppx_inline_test_lib__Runtime.Module_context.with_ in file "runtime-lib/runtime.ml", line 169, characters 6-13
  Called from Ppx_inline_test_lib__Runtime.test_module in file "runtime-lib/runtime.ml", line 527, characters 12-677
  in TEST_MODULE at file "src/lib/pickles/wrap.ml", line 286, characters 0-14270: gate finalization

@volhovm volhovm force-pushed the volhovm/14674-resurrect-lookup-pr-chunk1 branch from d188497 to 3fbf5c0 Compare December 19, 2023 17:29
@volhovm volhovm changed the title [DO NOT MERGE] Resurrecting lookup PR: Fix lookup has_zero_entry bug Resurrecting lookup PR: Fix lookup has_zero_entry bug Dec 19, 2023
@volhovm volhovm force-pushed the volhovm/14674-resurrect-lookup-pr-chunk1 branch from 3fbf5c0 to b7db98b Compare December 19, 2023 22:46
@volhovm volhovm force-pushed the volhovm/14674-resurrect-lookup-pr-chunk1 branch from b7db98b to 63c1aea Compare December 20, 2023 10:12
@volhovm
Copy link
Member Author

volhovm commented Dec 20, 2023

!ci-build-me

@volhovm
Copy link
Member Author

volhovm commented Dec 20, 2023

I confirm the tests passing locally in addition to the CI.

@volhovm volhovm marked this pull request as ready for review December 20, 2023 17:32
@volhovm volhovm requested a review from a team as a code owner December 20, 2023 17:32
@volhovm
Copy link
Member Author

volhovm commented Dec 21, 2023

!ci-build-me

@volhovm
Copy link
Member Author

volhovm commented Dec 21, 2023

!ci-build-me

1 similar comment
@volhovm
Copy link
Member Author

volhovm commented Dec 21, 2023

!ci-build-me

@dannywillems
Copy link
Member

Note: #14637 moves to alcotest and will conflict with this PR.

@dannywillems dannywillems merged commit 7a2751f into develop Dec 21, 2023
1 check passed
@dannywillems dannywillems deleted the volhovm/14674-resurrect-lookup-pr-chunk1 branch December 21, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants