Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Optim to 1, (keep existing compat) #403

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Optim package from ~1.8, ~1.9, ~1.10 to ~1.8, ~1.9, ~1.10, 1.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

Copy link
Contributor Author

github-actions bot commented Feb 15, 2025

Benchmark Results

master e6b9133... master/e6b9133c7c0bf1...
search/multithreading 17.6 ± 0.52 s 16.1 ± 0.56 s 1.1
search/serial 29 ± 0.44 s 28.5 ± 0.15 s 1.02
utils/best_of_sample 1.69 ± 0.5 μs 1.67 ± 1.3 μs 1.01
utils/check_constraints_x10 12.3 ± 3.4 μs 12.4 ± 3.4 μs 0.995
utils/compute_complexity_x10/Float64 2.19 ± 0.22 μs 2.14 ± 0.22 μs 1.02
utils/compute_complexity_x10/Int64 2.11 ± 0.2 μs 2.08 ± 0.21 μs 1.01
utils/compute_complexity_x10/nothing 1.49 ± 0.2 μs 1.5 ± 0.2 μs 0.993
utils/insert_random_op_x10 5.88 ± 2.1 μs 6.01 ± 2.1 μs 0.979
utils/next_generation_x100 0.352 ± 0.095 ms 0.421 ± 0.1 ms 0.837
utils/optimize_constants_x10 0.0355 ± 0.0078 s 0.035 ± 0.0081 s 1.02
utils/randomly_rotate_tree_x10 5.32 ± 0.64 μs 5.4 ± 0.7 μs 0.985
time_to_load 1.93 ± 0.02 s 2.02 ± 0.036 s 0.959

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@coveralls
Copy link

coveralls commented Feb 15, 2025

Pull Request Test Coverage Report for Build 13359109769

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 95.134%

Totals Coverage Status
Change from base Build 13338337691: 0.03%
Covered Lines: 3402
Relevant Lines: 3576

💛 - Coveralls

@MilesCranmer MilesCranmer merged commit d9534b2 into master Feb 17, 2025
17 checks passed
@MilesCranmer MilesCranmer deleted the compathelper/new_version/2025-01-24-00-11-44-868-03805423573 branch February 17, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants