Repository navigation
Support Julia 1.13 - #88
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7fd6def67a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Comment on lines
+12
to
+13
| @static if isdefined(Base, :code_ircode_by_type) && v"1.12.0-" <= VERSION | ||
| @unstable include("safe/auto_ir.jl") |
There was a problem hiding this comment.
When the package runs on Julia 1.13, this condition now loads the real checker, but README.md:59 still says the feature requires Julia 1.12.x and falls back to pass-through stubs on 1.13+. This directly contradicts the change and may lead 1.13 users to assume borrow checking is disabled; update the version guidance alongside the gate.
Useful? React with 👍 / 👎.
MilesCranmerBot
force-pushed
the
pr/113-support
branch
from
August 23, 2026 01:16
7fd6def to
8f248c3
Compare
MilesCranmerBot
added a commit
to MilesCranmerBot/BorrowChecker.jl
that referenced
this pull request
Aug 23, 2026
The lock-effect registry entries, the higher-order lock(f, l) model, and all four lock testsets are merged into MilesCranmer#88 (ported to the dissolved src/safe layout and verified green on 1.12 and 1.13-rc3). The src/auto module layout this branch was built on was dissolved by MilesCranmer#87, so the remaining rename is superseded upstream.
MilesCranmerBot
added a commit
to MilesCranmerBot/BorrowChecker.jl
that referenced
this pull request
Aug 23, 2026
The String/SubString ownership exemption and both testsets are merged into MilesCranmer#88 (ported to the dissolved src/safe layout, green on 1.12 and 1.13-rc3).
MilesCranmerBot
added a commit
to MilesCranmerBot/BorrowChecker.jl
that referenced
this pull request
Aug 23, 2026
MilesCranmer#88 removes the 1.13 ceiling instead of gating it off, so this branch's gate-tightening and README caveat no longer apply. Its README version line is updated in MilesCranmer#88.
MilesCranmerBot
added a commit
to MilesCranmerBot/BorrowChecker.jl
that referenced
this pull request
Aug 23, 2026
MilesCranmerBot
added a commit
to MilesCranmerBot/BorrowChecker.jl
that referenced
this pull request
Aug 23, 2026
MilesCranmerBot
added a commit
to MilesCranmerBot/BorrowChecker.jl
that referenced
this pull request
Aug 23, 2026
MilesCranmerBot
added a commit
to MilesCranmerBot/BorrowChecker.jl
that referenced
this pull request
Aug 23, 2026
Use Compiler.InferenceCache when the compiler exposes it and pass a source location to generated_body_to_codeinfo when required. Keep compiler-IR checking on Julia 1.12 and 1.13, with tested stubs on later versions. Treat String and SubString as value-semantic and remove the obsolete BORROWCHECKER_ONLY_AUTO test switch. Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>
MilesCranmerBot
force-pushed
the
pr/113-support
branch
from
August 23, 2026 22:47
8ab6f24 to
5e4da9f
Compare
MilesCranmer
approved these changes
Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Core.Compiler.InferenceCachewhen that API is available.generated_body_to_codeinfowhen required by the compiler API.StringandSubStringas value-semantic.BORROWCHECKER_ONLY_AUTOtest switch.Verification
All three runs used
Pkg.test()with the originaltest/Project.tomlstructure.