Skip to content

fix(auto): gate the IR checker off on Julia 1.13-rc - #83

Closed
MilesCranmerBot wants to merge 3 commits into
MilesCranmer:mainfrom
MilesCranmerBot:pr/gate-auto-on-113
Closed

MilesCranmerBot wants to merge 3 commits into
MilesCranmer:mainfrom
MilesCranmerBot:pr/gate-auto-on-113

Conversation

@MilesCranmerBot

Copy link
Copy Markdown
Contributor

Summary

Julia 1.13-rc removed get_indices(::Vector{Compiler.InferenceResult}, ::Core.MethodInstance), which BorrowChecker's reflection layer calls via Base.code_ircode_by_type. Because the auto checker was included for anything below 1.15, the nightly CI job hit runtime MethodErrors and hung to its 1h timeout — on every open PR, including docs-only ones.

The IR checker is now included only on 1.12.x; on 1.13+ @safe/@unsafe fall back to their warn-and-pass-through stubs until a proper 1.13 compatibility shim lands. The test runner's capability check is updated to match, so BORROWCHECKER_ONLY_AUTO=1 behaves consistently.

Test plan

  • 1.12: auto layer still included (Auto.check_ir defined); full auto suite green locally.
  • 1.10: unchanged (stubs).
  • Nightly should return to passing instead of timing out.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8691ad1a14

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/auto.jl Outdated
MilesCranmer#88 removes the 1.13 ceiling instead of gating it off, so this
branch's gate-tightening and README caveat no longer apply. Its
README version line is updated in MilesCranmer#88.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants