Add theming for OSS license screens #241
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| <activity | ||
| android:name="com.google.android.gms.oss.licenses.OssLicensesMenuActivity" | ||
| android:exported="false" /> | ||
| android:exported="false" | ||
| android:theme="@style/AppTheme" /> | ||
|
|
||
| <activity | ||
| android:name="com.google.android.gms.oss.licenses.OssLicensesActivity" | ||
| android:exported="false" /> | ||
| android:exported="false" | ||
| android:theme="@style/AppTheme" /> |
There was a problem hiding this comment.
[P1] Avoid removing action bar from Play Services license screens
Both license activities are now forced to use @style/AppTheme, which sets windowActionBar to false and windowNoTitle to true. The Google Play services OssLicensesMenuActivity/OssLicensesActivity provide their own content but rely on the host theme to supply an action bar for the title and the Up button. With the new theme the toolbar disappears, so the license UI shows neither a title nor back navigation unless the user presses the system back button. To keep the activities on-brand while preserving navigation, they should retain a theme variant with an action bar (e.g. AppThemeActionBar) or include an alternative navigation affordance.
Useful? React with 👍 / 👎.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68cc33fe5858832db954ddcef85dea25