Prevent duplicate startup work scheduling #217
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| public static void schedule(@NonNull Context context) { | ||
| if (!HAS_SCHEDULED.compareAndSet(false, true)) { | ||
| return; | ||
| } | ||
|
|
||
| OneTimeWorkRequest workRequest = new OneTimeWorkRequest.Builder( | ||
| StartupWorker.class).build(); | ||
| WorkManager.getInstance(context).enqueueUniqueWork( | ||
| WORK_NAME, ExistingWorkPolicy.KEEP, workRequest); |
There was a problem hiding this comment.
[P1] Guard boolean before enqueue causes permanent skip on failure
The new HAS_SCHEDULED.compareAndSet(false, true) runs before WorkManager.getInstance(context).enqueueUniqueWork(...). If getInstance throws (e.g. WorkManager not yet initialized in this process, a documented possibility) the method exits with the flag stuck at true. Subsequent retries in the same process will return immediately without scheduling the startup work, so initialization never happens. Consider setting the flag only after the enqueue succeeds or resetting it in a catch block to preserve retry behaviour when the first attempt fails.
Useful? React with 👍 / 👎.
Summary
StartupInitializer.scheduleso startup work only enqueues once per app launchTesting
https://chatgpt.com/codex/tasks/task_e_68c976429144832d99e05802da6b1aec