Skip to content

Conversation

@MihaiCristianCondrea
Copy link
Owner

Summary

  • return the Play Store base URL from DefaultHomeLocalDataSource and guard against null package names
  • add unit tests under data/source/local covering base, empty, and null package names plus the daily tip behavior

Testing

  • ./gradlew test (fails: Android SDK not configured in CI environment)

https://chatgpt.com/codex/tasks/task_e_68c976316340832da4917f85b05a48f7

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Comment on lines 20 to 23
@Override
public String getPlayStoreUrl() {
return "https://play.google.com/store/apps/details?id=com.d4rk.androidtutorials";
return PLAY_STORE_BASE_URL;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Returning base Play Store URL breaks app listing intent

The new getPlayStoreUrl() now returns only "https://play.google.com/store/apps/details?id=" without a package ID. HomeViewModel.getOpenPlayStoreIntent() uses this value directly to build the intent launched from the Home screen’s “Google Play” button, so after this change tapping the button will open a generic Play Store page (or an error) instead of the app’s listing (com.d4rk.androidtutorials). This is a functional regression; the method should still include the app’s package name, for example by appending a constant or the runtime package name.

Useful? React with 👍 / 👎.

@MihaiCristianCondrea MihaiCristianCondrea merged commit 38e9b78 into main Sep 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants