Skip to content

Commit

Permalink
Merge pull request #305 from yuyichao/api-lookup
Browse files Browse the repository at this point in the history
Make sure we are comparing agains the same API for the same extension
  • Loading branch information
MightyCreak authored Dec 4, 2024
2 parents 3be245e + 6248ea9 commit 590afc6
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/Console/Command/Parse.php
Original file line number Diff line number Diff line change
Expand Up @@ -412,8 +412,9 @@ private function compareMatricesAndSetModificationCommit(
Commit $commit
): void {
foreach ($matrix->getApiVersions() as $apiVersion) {
$prevApiVersion = $prevMatrix->getApiVersionByName($apiVersion->getName(), $apiVersion->getVersion());
foreach ($apiVersion->getExtensions() as $ext) {
$prevExt = $prevMatrix->getExtensionBySubstr($ext->getName());
$prevExt = $prevApiVersion !== null ? $prevApiVersion->getExtensionBySubstr($ext->getName()) : null;

$this->compareExtensionsAndSetModificationCommit($prevExt, $ext, $commit);
}
Expand Down

0 comments on commit 590afc6

Please sign in to comment.