Skip to content

refactor(face-embedding): fix BGR/RGB bug and improve embedding pipeline - #27

Closed
merakleee wants to merge 7 commits into
mainfrom
fix/improve_embedding
Closed

refactor(face-embedding): fix BGR/RGB bug and improve embedding pipeline#27
merakleee wants to merge 7 commits into
mainfrom
fix/improve_embedding

Conversation

@merakleee

Copy link
Copy Markdown

What changed

  • Fix silent accuracy bug: InsightFace expects BGR, not RGB
  • Replace sequential enrollment loop with asyncio.gather (parallel)
  • Add detect() method — removes direct model access from service layer
  • Pick best face by det_score instead of always taking faces[0]
  • Extract _embed_payload() for readability and testability

@merakleee
merakleee requested a review from wailbentafat March 20, 2026 01:52

@wailbentafat wailbentafat left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to run the code and fix the merge issues by rebasing

Comment thread app/service/face_embedding.py
Comment thread app/service/face_embedding.py
Comment thread app/service/filters.py
@merakleee merakleee closed this Mar 23, 2026
@Tyjfre-j
Tyjfre-j deleted the fix/improve_embedding branch July 20, 2026 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants