feat: add mc-collapsible component - #92
Conversation
There was a problem hiding this comment.
@kpadams94 thanks for the contribution, the code looks clean but there are some major blockers before merging this.
- checkout the issue #54 for the Figma design link. you should be following that rather than a custom design. there are missing icons
-
your component ships unstyled and the demo uses overrides that using render={} and className={} props. that is contrary what mcoli-ui library is going for (checkout contributing.md)
-
update the progress in the issue #54 since you're assigned. you can do this just by clicking the check-mark for what you id
-
move the collapsible component out of "coming soon" section
There was a problem hiding this comment.
@kpadams94 nice structuring of the work, you fit the patterns of the project perfectly
You can take a look at @hexxt-git remarks
- it would be even better to make the
mc-collapsible-demo.tsxfitting the figma (even with basic HTML Tags and className its okey since its behavioral component) so it becomes copy-paste ready in the docs - Also make sure when you finish to send screenshots of the demo component to take a look at the result
Thanks for contributing
|
Thanks for the feedback — I pushed commit
I was unable to mark the checkboxes in issue #54 because GitHub did not give me permission to edit the issue. All checklist items have been completed; could a maintainer please update them? |
Adel2411
left a comment
There was a problem hiding this comment.
@kpadams94 everything seems aligned with the issue and is ready to merge!
thanks for the contribution, let me know if you are looking forward to contribute on other upcoming issues


Summary
McCollapsiblewrapper using Base UI primitivesValidation
Closes #54