Skip to content

fix(leaderboard): remove dummyLeaderboardData, handle empty state wit… #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
micro-club-usthb merged 1 commit into from
Jul 30, 2026
Merged

fix(leaderboard): remove dummyLeaderboardData, handle empty state wit… #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/app/leaderboard/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ import {
PublicLeaderboardResponse,
} from "@/lib/api/leaderboard";
import LeaderboardComponent from "@/components/leaderboard/leaderboard";
import { Snowflake } from "lucide-react";
import { Snowflake, Table2 } from "lucide-react";
import { Notice } from "@/components/notice";


export function sortLeaderboardByScore(
Expand All @@ -27,9 +28,15 @@ export default async function Leaderboard() {
{leaderboardResponse.frozen && <Snowflake className="size-8 lg:size-12 text-white/80" />}
</h1>

<LeaderboardComponent
leaderboardData={sortedLeaderboardData}
/>
{sortedLeaderboardData.length === 0 ? (
<Notice
icon={Table2}
title="No entries yet"
message="Scores will appear here once teams start submitting."
/>
) : (
<LeaderboardComponent leaderboardData={sortedLeaderboardData} />
)}
<div className="h-12" />
</div>
);
Expand Down
20 changes: 4 additions & 16 deletions src/lib/api/leaderboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,6 @@ export type BulkScoreUpdatePayload = {
score: number;
};

export const dummyLeaderboardData: PublicLeaderboardEntry[] = [
{ team_name: "mouss w yakuza", total_score: 2 },
{ team_name: "berbochi", total_score: 8999 },
{ team_name: "mottenmenschen", total_score: 2015 },
{ team_name: "los galacticos", total_score: 140 },
];

/**
* Uncached on purpose, which also opts `/leaderboard` out of static generation.
* Prerendered, the public board froze at whatever the backend answered during
Expand All @@ -64,11 +57,11 @@ export async function getGlobalLeaderboard(): Promise<PublicLeaderboardResponse>

const data: PublicLeaderboardResponse = await response.json();

if (!data.leaderboard || data.leaderboard.length === 0) {
if (!data.leaderboard) {
return {
frozen: data.frozen ?? false,
frozen_at: data.frozen_at ?? null,
leaderboard: dummyLeaderboardData,
leaderboard: [],
};
}

Expand All @@ -88,16 +81,11 @@ export async function getAdminLeaderboard(): Promise<AdminLeaderboardResponse> {
if (!res.ok) throw new Error("Error retrieving the admin leaderboard");

const data: AdminLeaderboardResponse = await res.json();
if (!data.leaderboard || data.leaderboard.length === 0) {
if (!data.leaderboard) {
return {
frozen: data.frozen ?? false,
frozen_at: data.frozen_at ?? null,
leaderboard: dummyLeaderboardData.map((entry) => ({
team_id: "dummy",
team_name: entry.team_name,
per_challenge: [],
total_score: entry.total_score,
})),
leaderboard: [],
};
}

Expand Down
Loading