Course duplicates removed from future semesters #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gmfenech is attempting to deploy a commit to the Max Isom's projects Team on Vercel. A member of the Team first needs to authorize it. |
codetheweb
reviewed
Oct 20, 2024
src/lib/state/api.ts
Outdated
| for (const course of this.courses) { | ||
| if (!course.deletedAt) { | ||
| if (!course.deletedAt && !courses.some(existingCourse => `${existingCourse.subject}${existingCourse.crse}` === `${course.subject}${course.crse}`)) { |
There was a problem hiding this comment.
this is quite an expensive check (O(n^2)), let's use a Set
also, could you provide an example of the bug? I haven't seen it before so curious what it looks like
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #50 +/- ##
==========================================
- Coverage 31.84% 31.81% -0.04%
==========================================
Files 105 105
Lines 2490 2496 +6
Branches 410 410
==========================================
+ Hits 793 794 +1
- Misses 1640 1645 +5
Partials 57 57 ☔ View full report in Codecov by Sentry. |
|
Fixed on the backend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When viewing future semesters it will show multiple of the same courses. This may be due to it pulling courses from all past semesters.