Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move search bar to navbar #48

Merged
merged 9 commits into from
Oct 20, 2024

Conversation

DylanHojnoski
Copy link
Contributor

This moves the search bar into the navbar to save on vertical space. It also works properly on smaller screens.

move-search

Copy link

vercel bot commented Apr 19, 2024

@DylanHojnoski is attempting to deploy a commit to the Max Isom's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Apr 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mtucourses-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2024 0:02am

Copy link
Member

@codetheweb codetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a little more love before merging, I pushed a change to retain the size of the input & keep it centered but it looks a little off for the sm size now:

Screenshot 2024-04-21 at 3 02 09 PM

@DylanHojnoski
Copy link
Contributor Author

The navbar is looking as it was before but with the search bar in it now.

image

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 31.84%. Comparing base (912fcf5) to head (b9b81de).

Files with missing lines Patch % Lines
src/components/navbar.tsx 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   33.29%   31.84%   -1.45%     
==========================================
  Files         105      105              
  Lines        2481     2490       +9     
  Branches      406      410       +4     
==========================================
- Hits          826      793      -33     
- Misses       1590     1640      +50     
+ Partials       65       57       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@codetheweb codetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed a small change to avoid layout shift between pages, looks good now 👍

@codetheweb codetheweb merged commit f7e2e1e into Michigan-Tech-Courses:master Oct 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants