Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple baskets #31

Merged
merged 6 commits into from
Oct 14, 2021
Merged

Conversation

codetheweb
Copy link
Member

No description provided.

@linear
Copy link

linear bot commented Oct 12, 2021

MIC-62 Allow for multiple named baskets

Each should be associated with a specific semester.

@vercel
Copy link

vercel bot commented Oct 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/codetheweb/mtucourses-frontend/Bm6UhCYTzvk5mkqxuaoJK5t5KWm3
✅ Preview: https://mtucourses-frontend-git-max-mic-62-allow-for-51ff6b-codetheweb.vercel.app

@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #31 (3718178) into dev (4034658) will decrease coverage by 2.36%.
The diff coverage is 14.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #31      +/-   ##
==========================================
- Coverage   26.26%   23.90%   -2.37%     
==========================================
  Files          94       99       +5     
  Lines        1702     1820     +118     
  Branches      352      387      +35     
==========================================
- Hits          447      435      -12     
- Misses       1201     1333     +132     
+ Partials       54       52       -2     
Impacted Files Coverage Δ
src/components/basket/content.tsx 21.42% <0.00%> (-36.91%) ⬇️
src/components/basket/export-options/calendar.tsx 7.14% <0.00%> (-1.20%) ⬇️
...rc/components/basket/export-options/crn-script.tsx 4.87% <0.00%> (-0.13%) ⬇️
src/components/basket/export-options/image.tsx 3.03% <0.00%> (ø)
src/components/basket/export-options/index.tsx 5.88% <0.00%> (-0.79%) ⬇️
src/components/basket/table.tsx 13.95% <0.00%> (-0.34%) ⬇️
src/components/courses-table/details-row.tsx 8.69% <0.00%> (ø)
src/components/courses-table/row.tsx 2.85% <ø> (ø)
src/components/navbar.tsx 0.00% <0.00%> (ø)
src/components/sections-table/index.tsx 15.78% <0.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4034658...3718178. Read the comment docs.

@codetheweb codetheweb marked this pull request as ready for review October 14, 2021 00:56
@codetheweb codetheweb merged commit 85041eb into dev Oct 14, 2021
@codetheweb codetheweb deleted the max/mic-62-allow-for-multiple-named-baskets branch October 14, 2021 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant