Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend semester dropdown to future semesters #30

Merged
merged 5 commits into from
Oct 11, 2021

Conversation

codetheweb
Copy link
Member

  • Expand to future semesters
  • Move revalidation on semester change to reaction
  • Fix lint issues and resolve TODOs

@linear
Copy link

linear bot commented Oct 4, 2021

@vercel
Copy link

vercel bot commented Oct 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/codetheweb/mtucourses-frontend/3BEgLhwsJjTWXfKf9gYCxueWDy7d
✅ Preview: https://mtucourses-frontend-git-max-mic-56-extend-sem-990aea-codetheweb.vercel.app

@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #30 (aba150d) into dev (7b40c7c) will decrease coverage by 0.64%.
The diff coverage is 23.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #30      +/-   ##
==========================================
- Coverage   26.90%   26.26%   -0.65%     
==========================================
  Files          91       94       +3     
  Lines        1613     1702      +89     
  Branches      327      352      +25     
==========================================
+ Hits          434      447      +13     
- Misses       1123     1201      +78     
+ Partials       56       54       -2     
Impacted Files Coverage Δ
...rc/components/basket/export-options/crn-script.tsx 5.00% <0.00%> (-0.41%) ⬇️
src/components/courses-table/details-row.tsx 8.69% <0.00%> (-6.69%) ⬇️
src/components/courses-table/row.tsx 2.85% <0.00%> (-0.27%) ⬇️
src/components/navbar.tsx 0.00% <0.00%> (ø)
src/components/search-bar.tsx 42.30% <0.00%> (-5.70%) ⬇️
src/lib/search-filters.ts 5.79% <0.00%> (+0.79%) ⬆️
src/pages/about.tsx 0.00% <ø> (ø)
src/pages/help/registration-script.tsx 0.00% <0.00%> (ø)
src/lib/state/basket.ts 18.33% <2.63%> (-5.81%) ⬇️
src/lib/parse-credits-filter.ts 7.14% <7.14%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b40c7c...aba150d. Read the comment docs.

@codetheweb codetheweb merged commit 4034658 into dev Oct 11, 2021
@codetheweb codetheweb deleted the max/mic-56-extend-semester-dropdown-to-all branch October 11, 2021 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant