Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning when section times overlap #23

Merged
merged 1 commit into from
Sep 11, 2021

Conversation

codetheweb
Copy link
Member

No description provided.

@linear
Copy link

linear bot commented Sep 11, 2021

MIC-61 Compatibility warnings

Warn if schedule conflict between sections in basket

Warn if consecutive classes are too far apart (physical distance?)

Warn if section is full

@vercel
Copy link

vercel bot commented Sep 11, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/codetheweb/mtucourses-frontend/HejoUUTT1Kmx5gCaoy3XetgmHcpd
✅ Preview: https://mtucourses-frontend-git-max-mic-61-compatibil-ae2f59-codetheweb.vercel.app

@codecov
Copy link

codecov bot commented Sep 11, 2021

Codecov Report

Merging #23 (ef1cbc7) into dev (8dd3a64) will decrease coverage by 0.38%.
The diff coverage is 4.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #23      +/-   ##
==========================================
- Coverage   25.95%   25.57%   -0.39%     
==========================================
  Files          83       83              
  Lines        1410     1431      +21     
  Branches      277      282       +5     
==========================================
  Hits          366      366              
- Misses        998     1019      +21     
  Partials       46       46              
Impacted Files Coverage Δ
src/components/basket/content.tsx 27.27% <0.00%> (-6.07%) ⬇️
src/components/basket/table.tsx 10.34% <0.00%> (-0.37%) ⬇️
src/lib/basket-state.ts 10.84% <0.00%> (-2.59%) ⬇️
src/components/sections-table/time-display.tsx 16.00% <20.00%> (-1.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dd3a64...ef1cbc7. Read the comment docs.

@codetheweb codetheweb merged commit d6b4049 into dev Sep 11, 2021
@codetheweb codetheweb deleted the max/mic-61-compatibility-warnings branch September 11, 2021 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant