Skip to content

Meteor 3#183

Open
StorytellerCZ wants to merge 23 commits intomasterfrom
feature/meteor-3
Open

Meteor 3#183
StorytellerCZ wants to merge 23 commits intomasterfrom
feature/meteor-3

Conversation

@StorytellerCZ
Copy link
Member

No description provided.

Copy link

@dallman2 dallman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Very similar to the workarounds i was using locally. Please merge this

@acemtp
Copy link

acemtp commented Jun 18, 2024

Looks good., when will it be merged and a new package released?

@StorytellerCZ
Copy link
Member Author

@acemtp thanks for the ping. We'll need to look into replacing Travis, but I will try to release a beta in a few moments.

@StorytellerCZ StorytellerCZ marked this pull request as ready for review June 18, 2024 08:28
@acemtp
Copy link

acemtp commented Jun 18, 2024

Awesome, I try to clean my local patched package to be full ready for meteor 3.

I'll test the beta version as soon as available.

@StorytellerCZ
Copy link
Member Author

Published mizzao:user-status@2.0.0-beta.0

@StorytellerCZ
Copy link
Member Author

StorytellerCZ commented Jun 18, 2024

TODO:

@acemtp
Copy link

acemtp commented Jun 19, 2024

I used it on my project, it works fine! thanks for the release

@StorytellerCZ
Copy link
Member Author

Just need to update tests for async and we should be fine.

@StorytellerCZ StorytellerCZ added the need help Help is very much appreciated on this. label Jul 16, 2024
@diavrank
Copy link

diavrank commented Aug 1, 2024

Hope to test the beta version in the next few days

@wreiske
Copy link
Collaborator

wreiske commented Sep 12, 2024

@StorytellerCZ
Copy link
Member Author

@wreiske Published mizzao:user-status@2.0.0-rc.2 which should fix the issue.

@imongithubnow
Copy link

I don't understand why this great package is stuck here, also 2.0.0-rc.2 version don't works on Meteor 3, there are few points to fix to align the await/async features.
I'm sure I'm missing something but I don't understand what.

@StorytellerCZ
Copy link
Member Author

@imongithubnow it is simple, I don't have the time. PRs welcome.

@imongithubnow
Copy link

imongithubnow commented Jan 14, 2026

@imongithubnow it is simple, I don't have the time. PRs welcome.

ok this make a sense... :-)
I'm surprised that only a few changes were needed to fix it, so I don't understand why they haven't been made. I'm definitely doing something wrong... even if it works with these.
Anyway, I'll try to make a PR, out of curiosity.

@StorytellerCZ
Copy link
Member Author

@imongithubnow open the PR against this branch which will get it merged faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

need help Help is very much appreciated on this.

Projects

None yet

7 participants