Skip to content

Conversation

@LiberalArtist
Copy link
Contributor

I think this should be merged for the 8.12 release even if the fix for #73 isn't ready in time, or if we decide to hold it for more testing.

@Metaxal Metaxal merged commit 570bc28 into Metaxal:master Jan 8, 2024
@LiberalArtist
Copy link
Contributor Author

Thanks! Is there another step that needs to be done to cherry-pick this for 8.12? (Assuming you agree, @Metaxal, but that was the point of splitting this off from #81.)

cc @jbclements

@rfindler
Copy link
Collaborator

rfindler commented Jan 8, 2024

Unless there is a pressing bugfix here (I've lost track -- is there?) I think we should try to merge to regular master and see how it goes with internal use for one release cycle.

@LiberalArtist
Copy link
Contributor Author

This commit, merged as 570bc28, just comments out the part of the documentation that currently recommends that third-party packages use add-third-party-script-directory! under begin-for-syntax, since we have determined that the strategy:

  1. Breaks some environments; and
  2. Doesn't reliably work, even when it doesn't raise and warnings or errors.

That documentation change is all I propose cherry-picking for 8.12.

My attempt at providing a mechanism that does reliably work is over in #81, and I agree that it seems better to have a release cycle to confirm that whatever is eventually merged does work out well in practice.

I believe @Metaxal's 837921c last month already fixed the bug in 8.11[.1] that affected Debian, Guix, Nix, and probably others, and I'll plan to build a release candidate to make sure.

@rfindler
Copy link
Collaborator

rfindler commented Jan 8, 2024

Oh, shoot! I somehow thought this was the other pull request. And yes, this one does need to be explicitly merged, I see. I don't see who is the release manager for this repo, however. But yes, let's cherry-pick 1c44fd5 to the release branch!

@Metaxal
Copy link
Owner

Metaxal commented Jan 10, 2024

I agree that we should probably use 1c44fd5 for 8.12, so as to give us more time to test the new design.

@jbclements
Copy link
Collaborator

jbclements commented Jan 11, 2024

@Metaxal you're the release manager for the quickscript repos, you should be able to cherry-pick this for the release; to see what the commands should be, use Ryan's repo-manager-app, available at:

https://pre-release.racket-lang.org/status/?repo=Metaxal/quickscript

Let me know if you have any questions!

@Metaxal
Copy link
Owner

Metaxal commented Jan 11, 2024 via email

Metaxal pushed a commit that referenced this pull request Jan 12, 2024
@Metaxal
Copy link
Owner

Metaxal commented Jan 12, 2024

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants