Skip to content

Conversation

ncarazon
Copy link
Contributor

@ncarazon ncarazon commented Sep 11, 2025

Closes #3423

This PR enables discrete groups. I've tested question creation, forecast creation and withdraw. Everything worked as expected.

@ncarazon ncarazon force-pushed the feat/discrete-groups branch from 4f9dc36 to be76130 Compare September 12, 2025 08:04
@ncarazon ncarazon marked this pull request as ready for review September 12, 2025 08:05
@ncarazon ncarazon requested a review from lsabor September 12, 2025 08:05
Copy link
Contributor

@lsabor lsabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, it doesn't quite work.
The first added subquestion works properly, but when you add an additional subquestion, it copies directly the nominal "range_min" and "range_max" . This was annoying enough to implement, and was the main reason why I didn't just launch them at the time.
image
image

After creation, the first one has range_min / range_max of -0.5 and 10.5 and inbound outcome count of 11 which are all correct,
but the second one has range_min / range_max of 0.0 and 10.0 and inbound outcome count of 10 which are all incorrect.

We need to make sure additional subquestions that copy from an earlier question copy the real value (-0.5) not the nominal value (0.0).

If this explanation isn't clear, i can go into more detail on a call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discrete groups
2 participants