-
Notifications
You must be signed in to change notification settings - Fork 5.4k
release(runway): cherry-pick fix: added support link to unlock page cp-13.10.0 #37986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gauthierpetetin
merged 1 commit into
release/13.10.0
from
runway-cherry-pick-13.10.0-1763571323
Nov 20, 2025
Merged
release(runway): cherry-pick fix: added support link to unlock page cp-13.10.0 #37986
gauthierpetetin
merged 1 commit into
release/13.10.0
from
runway-cherry-pick-13.10.0-1763571323
Nov 20, 2025
+66
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…37967) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/37967?quickstart=1) In this PR, we have enabled the MetaMask Support link in unlock page. Jira Link: https://consensyssoftware.atlassian.net/browse/SL-329 Figma Link: https://www.figma.com/design/pViOUcmjwhEzFsdrwknpNc/Onboarding-Redesign?node-id=18656-27472&m=dev ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: added the support link back in unlock page. ## **Related issues** Fixes: ## **Manual testing steps** 1. Open Extension 2. Create Wallet 3. Lock the app 4. Validate changes in unlock page. 5. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> <img width="1728" height="1007" alt="Screenshot 2025-11-19 at 1 06 31 PM" src="https://github.com/user-attachments/assets/9dbf610c-1d7a-4aad-9a9f-de52bc23a71a" /> ### **After** <!-- [screenshots/recordings] --> <img width="385" height="1002" alt="Screenshot 2025-11-19 at 12 51 52 PM" src="https://github.com/user-attachments/assets/8172d54e-09d1-4eb7-ae85-b0b56fa9f1fc" /> <img width="381" height="994" alt="Screenshot 2025-11-19 at 12 52 07 PM" src="https://github.com/user-attachments/assets/c29c2a40-dc66-402b-9812-63e008d116f2" /> <img width="498" height="761" alt="Screenshot 2025-11-19 at 12 52 37 PM" src="https://github.com/user-attachments/assets/58f4cd6e-89c0-46b1-8b48-44fcf5f90c40" /> <img width="494" height="647" alt="Screenshot 2025-11-19 at 12 53 04 PM" src="https://github.com/user-attachments/assets/69b15d7f-ff87-4d6d-b9cc-02d2f3379ff4" /> <img width="1727" height="987" alt="Screenshot 2025-11-19 at 12 53 20 PM" src="https://github.com/user-attachments/assets/1eeabfae-30c7-4dd0-8090-0701eb8cba88" /> <img width="1722" height="1031" alt="Screenshot 2025-11-19 at 12 53 38 PM" src="https://github.com/user-attachments/assets/e5eea7ee-d609-4956-b397-a29b75e74e93" /> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adds a support link with tracking to the unlock page, introduces popup-specific logo spacing via a new isPopup prop, and tweaks margins/spacing. > > - **Unlock Page UI**: > - **Support link**: Adds “Need help? Contact MetaMask support” with external link and metrics tracking (`SupportLinkClicked`). > - **Spacing tweaks**: Reduces `Forgot password?` margin (`marginBottom` 6→4); adjusts `unlock-page__mascot-container__horizontal-logo` default margin (60px→24px); adds popup modifier `--popup` to remove bottom margin. > - **Logic/Props**: > - Passes new `isPopup` prop from container (via `getEnvironmentType() === ENVIRONMENT_TYPE_POPUP`) to component; applies conditional class to `MetaFoxHorizontalLogo`. > - **Styles**: > - Updates `index.scss` to add `&--popup` modifier and new margins. > - **Tests**: > - Updates snapshot to reflect new support link and spacing changes. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 1001a7e. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Lwin <[email protected]>
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [477688e]
UI Startup Metrics (1247 ± 98 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
gauthierpetetin
approved these changes
Nov 19, 2025
Collaborator
Builds ready [477688e]
UI Startup Metrics (1247 ± 98 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
Collaborator
|
No release label on PR. Adding release label release-13.10.0 on PR, as PR was cherry-picked in branch 13.10.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-13.10.0
Issue or pull request that will be included in release 13.10.0
team-bots
Bot team (for MetaMask Bot, Runway Bot, etc.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we have enabled the MetaMask Support link in unlock page.
Jira Link: https://consensyssoftware.atlassian.net/browse/SL-329
Figma Link:
https://www.figma.com/design/pViOUcmjwhEzFsdrwknpNc/Onboarding-Redesign?node-id=18656-27472&m=dev
Changelog
CHANGELOG entry: added the support link back in unlock page.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask
Extension Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Adds a help/support link to the unlock page and tweaks horizontal logo spacing with a popup-specific style, wiring
isPopupfrom container to component.ui/pages/unlock-page/unlock-page.component.js)SUPPORT_LINKand tracking.marginBottom6 → 4).MetaFoxHorizontalLogowhenisPopupis true.isPopuptoPropTypes.ui/pages/unlock-page/index.scss)unlock-page__mascot-container__horizontal-logomargin-bottom (60px → 24px) and add--popupmodifier (margin-bottom: 0).ui/pages/unlock-page/unlock-page.container.js)isPopupviagetEnvironmentType()and pass to component; reuse for restore-in-browser logic.__snapshots__/unlock-page.test.js.snap)Written by Cursor Bugbot for commit 477688e. This will update automatically on new commits. Configure here.
Co-authored-by: Lwin [email protected] 355e33f