feat: adding context for dapp swap #37980

jpuri · 2025-11-19T14:31:27Z

Description

PR is doing 2 things:

Add new context for dapp swap and not use confirmContext
Add flag for dapp swap QA

Changelog

CHANGELOG entry:

Related issues

Fixes: MetaMask/metamask-mobile#22928

Manual testing steps

Trigger swap request locally
In development mode best available quote should always be visible

Screenshots/Recordings

NA

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds a dedicated DappSwapContext for swap UI state, migrates confirmation components/hooks to it, and introduces a dappSwapQa flag affecting comparison banner visibility and quote handling.

Context & State Management
- Add DappSwapContextProvider and useDappSwapContext for selectedQuote and isQuotedSwapDisplayedInInfo.
- Remove swap-related fields from ConfirmContext.
- Wrap Confirm flow, tests, and Storybook stories with DappSwapContextProvider.
Component/Hook Integration
- Migrate to new context in DappSwapComparisonBanner, BaseTransactionInfo, EditGasFeesRow, SelectedGasFeeToken, TransactionData, EstimatedPointsSection, useResimulationAlert, useTransactionConfirm.
- Update swap actions/metrics: useDappSwapActions, useDappSwapComparisonMetrics, reward text hook.
Feature Flags & Behavior
- Add dappSwapQa flag; banner displays if threshold met or QA enabled with a quote.
- Sync selectedQuote into context; adjust display/CTA metrics events.
Data & Utils
- useDappSwapUSDValues skips native addresses when fetching fiat rates.
Tests/Stories
- Update tests to mock useDappSwapContext; adjust expectations.
- Update render helpers to include DappSwapContextProvider.

^{Written by Cursor Bugbot for commit c87eecc. This will update automatically on new commits. Configure here.}

…tension into tooltip_fix

…ask-extension into dapp_swap_metrics

...es/confirmations/components/confirm/info/shared/edit-gas-fees-row/edit-gas-fees-row.test.tsx

metamaskbot · 2025-11-19T19:17:42Z

Builds ready [502cf4d]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1212 ± 97 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1212	1047	1689	97	1276	1355
			load	1035	881	1404	88	1093	1167
			domContentLoaded	1029	873	1393	87	1088	1159
			domInteractive	23	13	159	21	21	68
			firstPaint	542	83	1181	410	1047	1142
			backgroundConnect	210	194	248	10	215	231
			firstReactRender	29	20	66	10	34	50
			getState	32	16	64	10	37	50
			initialActions	1	0	3	1	1	2
			loadScripts	826	675	1171	85	886	954
			setupStore	10	7	25	4	11	19
			numNetworkReqs	13	6	76	19	6	70
	Browserify	Power User Home	uiStartup	1812	1539	3302	259	1932	2306
			load	975	860	1921	160	975	1368
			domContentLoaded	960	852	1912	160	955	1361
			domInteractive	35	15	194	39	28	156
			firstPaint	556	111	1926	386	904	1256
			backgroundConnect	218	202	260	10	223	237
			firstReactRender	83	41	157	18	91	115
			getState	175	139	356	39	184	258
			initialActions	1	0	2	1	1	2
			loadScripts	758	655	1686	159	754	1159
			setupStore	20	9	57	9	29	36
			numNetworkReqs	96	69	207	30	106	182
	Webpack	Standard Home	uiStartup	840	698	1182	94	867	1016
			load	581	533	919	68	587	746
			domContentLoaded	573	528	902	65	576	731
			domInteractive	18	11	90	13	15	52
			firstPaint	211	53	913	206	179	736
			backgroundConnect	28	11	99	20	28	87
			firstReactRender	36	19	221	25	39	62
			getState	19	11	47	6	21	28
			initialActions	1	0	3	1	1	2
			loadScripts	570	526	894	64	574	723
			setupStore	12	6	28	4	14	19
			numNetworkReqs	14	6	79	20	8	74
	Webpack	Power User Home	uiStartup	1312	1151	2361	200	1347	1688
			load	640	562	1162	120	634	944
			domContentLoaded	622	550	1116	113	613	906
			domInteractive	28	13	152	33	18	120
			firstPaint	277	64	1101	267	227	910
			backgroundConnect	45	11	217	34	65	106
			firstReactRender	75	35	101	13	81	91
			getState	151	100	209	18	162	185
			initialActions	1	0	5	1	1	1
			loadScripts	620	548	1105	111	611	898
			setupStore	17	6	70	15	27	57
			numNetworkReqs	120	68	242	42	132	211
Firefox	Browserify	Standard Home	uiStartup	1207	1056	1682	105	1271	1394
			load	1017	908	1214	71	1060	1159
			domContentLoaded	1016	908	1212	71	1060	1159
			domInteractive	56	30	186	32	81	129
			firstPaint	-	-	-	-	-	-
			backgroundConnect	35	20	174	21	35	74
			firstReactRender	22	18	47	6	22	35
			getState	10	6	68	8	9	21
			initialActions	1	0	3	1	1	2
			loadScripts	995	893	1197	65	1033	1117
			setupStore	13	6	214	27	9	32
			numNetworkReqs	12	6	64	14	8	53
	Browserify	Power User Home	uiStartup	2619	2042	3642	318	2770	3258
			load	1143	931	1721	184	1175	1585
			domContentLoaded	1143	931	1721	184	1175	1585
			domInteractive	139	31	611	137	153	522
			firstPaint	-	-	-	-	-	-
			backgroundConnect	206	24	836	230	228	767
			firstReactRender	85	36	148	20	98	123
			getState	248	78	912	245	194	829
			initialActions	2	0	31	3	2	6
			loadScripts	1108	911	1693	178	1125	1563
			setupStore	126	6	804	191	118	742
			numNetworkReqs	96	58	228	44	92	201
	Webpack	Standard Home	uiStartup	1438	1267	1828	124	1486	1723
			load	1223	1071	1486	96	1288	1431
			domContentLoaded	1223	1071	1486	96	1288	1431
			domInteractive	71	27	235	45	88	160
			firstPaint	-	-	-	-	-	-
			backgroundConnect	42	21	126	22	45	92
			firstReactRender	28	20	83	11	30	38
			getState	14	6	98	17	11	49
			initialActions	1	0	3	1	1	2
			loadScripts	1194	1050	1429	92	1262	1404
			setupStore	13	5	71	12	10	46
			numNetworkReqs	13	6	71	17	7	64
	Webpack	Power User Home	uiStartup	2962	2295	3784	347	3143	3646
			load	1431	1111	2112	208	1599	1819
			domContentLoaded	1431	1111	2112	208	1599	1819
			domInteractive	144	29	677	132	170	460
			firstPaint	-	-	-	-	-	-
			backgroundConnect	212	29	856	225	244	757
			firstReactRender	94	38	279	34	107	145
			getState	230	71	904	245	177	849
			initialActions	2	0	8	2	3	7
			loadScripts	1391	1092	2084	204	1539	1787
			setupStore	127	5	795	192	106	765
			numNetworkReqs	97	57	229	43	109	211

📊 Page Load Benchmark Results

Current Commit: 502cf4d | Date: 11/19/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±46ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 724ms (±42ms) 🟢 | historical mean value: 730ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 78ms (±17ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	46ms	1.01s	1.42s	1.08s	1.42s
domContentLoaded	724ms	42ms	702ms	1.06s	750ms	1.06s
firstPaint	78ms	17ms	60ms	240ms	88ms	240ms
firstContentfulPaint	78ms	17ms	60ms	240ms	88ms	240ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

ui/pages/confirmations/hooks/transactions/dapp-swap-comparison/useDappSwapComparisonInfo.ts

metamaskbot · 2025-11-20T04:08:15Z

Builds ready [f415c8e]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1291 ± 101 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1291	1124	1567	101	1366	1465
			load	1101	935	1371	94	1172	1265
			domContentLoaded	1094	932	1355	92	1162	1261
			domInteractive	25	14	95	18	22	77
			firstPaint	607	96	1376	450	1106	1247
			backgroundConnect	230	213	267	10	236	250
			firstReactRender	31	20	66	11	34	53
			getState	34	17	77	11	39	60
			initialActions	1	0	3	1	1	2
			loadScripts	872	725	1137	91	942	1033
			setupStore	11	7	36	5	12	26
			numNetworkReqs	13	6	75	19	6	69
	Browserify	Power User Home	uiStartup	1848	1560	2727	243	1987	2356
			load	989	874	1576	157	997	1486
			domContentLoaded	973	866	1567	154	969	1462
			domInteractive	34	16	196	39	29	165
			firstPaint	566	79	1580	400	914	1416
			backgroundConnect	222	196	291	13	228	246
			firstReactRender	78	47	120	12	85	94
			getState	174	127	367	45	187	275
			initialActions	1	0	4	1	1	2
			loadScripts	769	665	1346	151	769	1254
			setupStore	20	7	73	11	26	42
			numNetworkReqs	127	70	279	45	163	225
	Webpack	Standard Home	uiStartup	862	718	1162	91	885	1047
			load	609	555	942	75	615	823
			domContentLoaded	602	551	925	72	609	796
			domInteractive	18	11	69	13	15	54
			firstPaint	195	56	932	206	181	760
			backgroundConnect	26	10	96	17	27	74
			firstReactRender	33	19	69	11	40	46
			getState	19	12	29	5	23	28
			initialActions	1	0	3	1	1	1
			loadScripts	599	548	917	70	607	788
			setupStore	12	6	22	4	14	18
			numNetworkReqs	13	6	75	19	8	71
	Webpack	Power User Home	uiStartup	1376	1190	2279	213	1404	1834
			load	678	587	1382	146	688	1038
			domContentLoaded	657	573	1304	135	649	1004
			domInteractive	34	13	283	52	19	179
			firstPaint	363	60	1186	296	608	996
			backgroundConnect	46	13	192	34	67	112
			firstReactRender	81	44	110	14	88	105
			getState	150	120	211	19	162	197
			initialActions	1	0	2	0	1	1
			loadScripts	654	570	1296	133	647	996
			setupStore	20	7	67	16	35	54
			numNetworkReqs	97	69	210	36	119	184
Firefox	Browserify	Standard Home	uiStartup	1236	1080	1668	120	1300	1545
			load	1042	916	1302	83	1098	1230
			domContentLoaded	1041	916	1302	84	1097	1229
			domInteractive	54	30	154	29	81	110
			firstPaint	-	-	-	-	-	-
			backgroundConnect	38	20	187	22	41	77
			firstReactRender	21	18	37	4	21	34
			getState	13	5	172	20	10	36
			initialActions	1	0	3	1	1	2
			loadScripts	1018	903	1268	75	1073	1173
			setupStore	10	5	31	5	10	25
			numNetworkReqs	12	6	67	14	8	55
	Browserify	Power User Home	uiStartup	2795	1961	3709	348	2974	3459
			load	1245	957	1849	186	1299	1646
			domContentLoaded	1245	957	1848	186	1298	1646
			domInteractive	154	28	639	148	153	573
			firstPaint	-	-	-	-	-	-
			backgroundConnect	262	27	994	283	353	903
			firstReactRender	92	41	181	22	103	131
			getState	238	71	899	235	190	864
			initialActions	3	1	38	5	3	7
			loadScripts	1199	939	1792	180	1240	1603
			setupStore	130	8	802	200	124	748
			numNetworkReqs	96	55	197	39	95	191
	Webpack	Standard Home	uiStartup	1437	1220	1840	127	1497	1757
			load	1221	1052	1496	100	1283	1428
			domContentLoaded	1221	1052	1496	100	1283	1427
			domInteractive	69	27	229	46	85	158
			firstPaint	-	-	-	-	-	-
			backgroundConnect	38	18	120	17	42	72
			firstReactRender	29	20	79	10	31	51
			getState	12	6	47	10	11	43
			initialActions	1	0	2	0	1	2
			loadScripts	1195	1037	1433	94	1255	1409
			setupStore	14	6	185	22	10	42
			numNetworkReqs	13	6	72	17	7	63
	Webpack	Power User Home	uiStartup	2817	2000	3782	337	2969	3512
			load	1369	1087	1790	182	1520	1741
			domContentLoaded	1368	1086	1790	182	1520	1741
			domInteractive	125	28	598	114	139	431
			firstPaint	-	-	-	-	-	-
			backgroundConnect	158	29	795	168	170	647
			firstReactRender	87	38	252	27	93	128
			getState	265	74	900	263	230	856
			initialActions	3	0	45	5	2	7
			loadScripts	1334	1054	1753	176	1479	1703
			setupStore	152	5	835	227	108	763
			numNetworkReqs	94	54	219	45	91	210

📊 Page Load Benchmark Results

Current Commit: f415c8e | Date: 11/20/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±41ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 716ms (±37ms) 🟢 | historical mean value: 729ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 75ms (±11ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	41ms	1.01s	1.36s	1.06s	1.36s
domContentLoaded	716ms	37ms	698ms	1.01s	741ms	1.01s
firstPaint	75ms	11ms	60ms	168ms	84ms	168ms
firstContentfulPaint	75ms	11ms	60ms	168ms	84ms	168ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

ui/pages/confirmations/hooks/transactions/dapp-swap-comparison/useDappSwapUSDValues.ts

...confirmations/components/confirm/dapp-swap-comparison-banner/dapp-swap-comparison-banner.tsx

metamaskbot · 2025-11-20T05:12:11Z

Builds ready [8fae2a4]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1239 ± 96 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1239	1051	1474	96	1295	1430
			load	1062	907	1305	92	1125	1229
			domContentLoaded	1054	896	1298	92	1119	1221
			domInteractive	24	13	108	19	21	74
			firstPaint	621	76	1318	431	1072	1183
			backgroundConnect	219	200	270	13	224	240
			firstReactRender	28	20	48	7	31	46
			getState	31	16	76	10	33	52
			initialActions	1	0	3	1	1	2
			loadScripts	843	693	1066	88	909	989
			setupStore	10	5	33	3	11	17
			numNetworkReqs	13	6	74	19	6	70
	Browserify	Power User Home	uiStartup	1850	1538	2778	255	2004	2358
			load	988	873	1632	149	991	1407
			domContentLoaded	973	867	1609	146	965	1374
			domInteractive	36	15	201	42	27	165
			firstPaint	545	94	1620	420	922	1394
			backgroundConnect	220	198	270	11	226	240
			firstReactRender	78	46	139	14	83	96
			getState	178	135	370	49	188	315
			initialActions	1	0	5	1	1	2
			loadScripts	769	669	1375	143	766	1169
			setupStore	20	10	67	11	24	44
			numNetworkReqs	110	70	240	37	122	186
	Webpack	Standard Home	uiStartup	843	706	1149	86	854	1059
			load	596	545	873	66	607	762
			domContentLoaded	589	541	861	62	602	747
			domInteractive	17	11	67	11	15	52
			firstPaint	199	59	815	187	191	581
			backgroundConnect	26	10	91	18	26	81
			firstReactRender	33	20	88	13	38	67
			getState	19	11	34	5	23	27
			initialActions	1	0	4	1	1	2
			loadScripts	586	539	852	60	599	739
			setupStore	11	5	24	4	14	17
			numNetworkReqs	13	6	79	19	8	75
	Webpack	Power User Home	uiStartup	1333	1162	2241	209	1459	1818
			load	652	572	1281	134	661	992
			domContentLoaded	633	560	1234	124	632	959
			domInteractive	29	13	240	39	18	142
			firstPaint	302	60	1238	280	569	943
			backgroundConnect	46	11	188	34	67	118
			firstReactRender	76	40	99	12	82	91
			getState	154	102	273	23	162	201
			initialActions	1	0	1	0	1	1
			loadScripts	630	558	1225	122	630	950
			setupStore	17	7	56	13	30	39
			numNetworkReqs	100	69	245	37	118	185
Firefox	Browserify	Standard Home	uiStartup	1300	1100	1757	126	1386	1553
			load	1091	952	1347	89	1156	1251
			domContentLoaded	1090	952	1347	89	1155	1250
			domInteractive	68	32	242	45	86	171
			firstPaint	-	-	-	-	-	-
			backgroundConnect	39	21	135	18	47	84
			firstReactRender	24	19	54	6	24	37
			getState	12	6	91	12	11	22
			initialActions	1	0	3	1	2	2
			loadScripts	1067	936	1302	85	1131	1232
			setupStore	13	6	149	16	12	27
			numNetworkReqs	12	6	64	14	7	53
	Browserify	Power User Home	uiStartup	2576	2014	3355	222	2746	2948
			load	1163	953	1558	149	1200	1496
			domContentLoaded	1162	953	1558	149	1200	1496
			domInteractive	126	34	505	106	151	404
			firstPaint	-	-	-	-	-	-
			backgroundConnect	168	26	960	173	221	551
			firstReactRender	84	41	142	19	93	124
			getState	255	69	828	256	208	814
			initialActions	2	0	16	2	2	7
			loadScripts	1128	937	1540	142	1159	1449
			setupStore	100	10	744	151	97	595
			numNetworkReqs	95	65	226	41	94	204
	Webpack	Standard Home	uiStartup	1449	1231	2133	145	1490	1766
			load	1229	1064	1565	96	1295	1413
			domContentLoaded	1228	1064	1565	96	1295	1413
			domInteractive	65	27	181	38	84	140
			firstPaint	-	-	-	-	-	-
			backgroundConnect	43	19	142	25	43	94
			firstReactRender	30	21	152	16	30	69
			getState	15	6	180	22	11	48
			initialActions	1	0	2	1	1	2
			loadScripts	1200	1051	1493	89	1260	1361
			setupStore	12	5	98	13	10	35
			numNetworkReqs	13	6	70	16	7	63
	Webpack	Power User Home	uiStartup	2860	2048	3688	314	3034	3491
			load	1382	1058	1928	201	1524	1757
			domContentLoaded	1382	1058	1928	201	1524	1757
			domInteractive	130	29	519	118	154	442
			firstPaint	-	-	-	-	-	-
			backgroundConnect	151	28	799	164	185	599
			firstReactRender	87	39	239	25	92	132
			getState	279	71	903	286	214	872
			initialActions	3	1	50	7	2	7
			loadScripts	1349	1043	1815	194	1476	1736
			setupStore	135	6	813	212	113	745
			numNetworkReqs	95	54	230	47	92	216

📊 Page Load Benchmark Results

Current Commit: 8fae2a4 | Date: 11/20/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 982ms (±39ms) 🟢 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 680ms (±35ms) 🟢 | historical mean value: 729ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±12ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	982ms	39ms	947ms	1.27s	1.01s	1.27s
domContentLoaded	680ms	35ms	654ms	936ms	704ms	936ms
firstPaint	76ms	12ms	64ms	184ms	80ms	184ms
firstContentfulPaint	76ms	12ms	64ms	184ms	80ms	184ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

metamaskbot · 2025-11-20T06:17:16Z

Builds ready [d70ee9e]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1202 ± 100 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1202	1030	1485	100	1272	1376
			load	1031	874	1265	86	1091	1178
			domContentLoaded	1023	869	1255	87	1083	1172
			domInteractive	22	13	83	15	21	67
			firstPaint	665	75	1263	411	1057	1176
			backgroundConnect	208	194	290	15	211	234
			firstReactRender	27	19	52	8	30	45
			getState	30	13	60	9	33	48
			initialActions	1	0	3	1	1	2
			loadScripts	823	674	1056	86	881	962
			setupStore	10	6	41	4	10	19
			numNetworkReqs	13	6	77	20	6	74
	Browserify	Power User Home	uiStartup	1884	1532	3683	281	2061	2274
			load	1007	868	1990	166	1001	1418
			domContentLoaded	991	863	1974	165	976	1406
			domInteractive	35	17	177	37	29	154
			firstPaint	607	104	1987	421	938	1383
			backgroundConnect	225	198	285	14	232	256
			firstReactRender	80	45	137	15	90	111
			getState	175	132	444	47	199	278
			initialActions	1	0	5	1	1	3
			loadScripts	783	670	1705	162	771	1200
			setupStore	21	9	57	11	28	46
			numNetworkReqs	98	69	194	29	111	173
	Webpack	Standard Home	uiStartup	843	707	1100	85	860	1033
			load	596	540	845	65	602	779
			domContentLoaded	589	535	824	62	597	760
			domInteractive	17	11	62	12	14	55
			firstPaint	210	58	828	213	184	756
			backgroundConnect	27	12	100	17	25	68
			firstReactRender	33	19	146	14	38	45
			getState	19	12	37	5	22	28
			initialActions	1	0	4	1	1	2
			loadScripts	586	533	816	60	595	752
			setupStore	12	4	31	4	14	19
			numNetworkReqs	13	6	75	19	8	71
	Webpack	Power User Home	uiStartup	1333	1148	2393	216	1449	1807
			load	649	572	1142	118	655	987
			domContentLoaded	629	557	1072	106	634	954
			domInteractive	30	13	169	36	19	140
			firstPaint	305	64	978	257	580	783
			backgroundConnect	46	11	223	41	60	127
			firstReactRender	76	37	110	13	84	91
			getState	146	106	199	20	157	189
			initialActions	1	0	2	0	1	1
			loadScripts	627	555	1064	105	632	945
			setupStore	20	6	66	16	33	57
			numNetworkReqs	110	69	259	47	118	225
Firefox	Browserify	Standard Home	uiStartup	1279	1101	1754	127	1344	1560
			load	1074	944	1337	88	1128	1238
			domContentLoaded	1073	944	1337	88	1123	1235
			domInteractive	65	29	233	42	83	142
			firstPaint	-	-	-	-	-	-
			backgroundConnect	42	23	167	22	45	81
			firstReactRender	22	18	46	4	23	26
			getState	12	6	167	18	10	25
			initialActions	1	0	2	1	1	2
			loadScripts	1047	927	1318	82	1098	1207
			setupStore	11	5	75	10	10	35
			numNetworkReqs	12	6	64	15	7	56
	Browserify	Power User Home	uiStartup	2798	1882	3812	398	3071	3588
			load	1234	991	1853	204	1330	1671
			domContentLoaded	1233	991	1852	203	1329	1671
			domInteractive	156	32	684	152	166	561
			firstPaint	-	-	-	-	-	-
			backgroundConnect	255	28	986	276	373	912
			firstReactRender	89	44	165	21	94	139
			getState	240	67	914	241	185	835
			initialActions	3	1	23	3	2	7
			loadScripts	1187	973	1708	189	1221	1627
			setupStore	116	6	799	171	113	686
			numNetworkReqs	99	60	220	40	107	197
	Webpack	Standard Home	uiStartup	1477	1241	1991	141	1508	1817
			load	1257	1092	1541	99	1295	1468
			domContentLoaded	1257	1092	1541	99	1295	1468
			domInteractive	84	30	235	54	103	232
			firstPaint	-	-	-	-	-	-
			backgroundConnect	40	22	130	24	38	113
			firstReactRender	28	19	73	8	28	41
			getState	13	7	155	18	11	43
			initialActions	1	0	11	1	2	2
			loadScripts	1233	1076	1471	93	1275	1427
			setupStore	12	6	87	11	11	36
			numNetworkReqs	13	6	71	18	7	67
	Webpack	Power User Home	uiStartup	2992	2105	3916	355	3198	3682
			load	1476	1180	1966	206	1681	1830
			domContentLoaded	1476	1180	1966	206	1680	1830
			domInteractive	141	28	627	127	156	458
			firstPaint	-	-	-	-	-	-
			backgroundConnect	193	27	965	205	218	651
			firstReactRender	91	44	222	30	97	160
			getState	276	84	900	265	229	872
			initialActions	5	0	69	11	3	8
			loadScripts	1439	1161	1834	201	1638	1801
			setupStore	128	5	801	195	124	728
			numNetworkReqs	94	55	231	46	91	212

📊 Page Load Benchmark Results

Current Commit: d70ee9e | Date: 11/20/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±37ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 717ms (±34ms) 🟢 | historical mean value: 729ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±11ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	37ms	1.00s	1.30s	1.06s	1.30s
domContentLoaded	717ms	34ms	692ms	976ms	739ms	976ms
firstPaint	76ms	11ms	60ms	164ms	88ms	164ms
firstContentfulPaint	76ms	11ms	60ms	164ms	88ms	164ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

chaitanyapotti

lgtm for web3auth code owner files

metamaskbot · 2025-11-20T08:45:01Z

Builds ready [c87eecc]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1198 ± 101 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1198	1045	1558	101	1276	1369
			load	1023	878	1344	92	1101	1174
			domContentLoaded	1016	873	1336	91	1095	1170
			domInteractive	23	13	84	18	20	79
			firstPaint	605	83	1357	412	1038	1149
			backgroundConnect	210	194	270	11	213	229
			firstReactRender	28	19	51	7	32	43
			getState	34	17	101	14	41	59
			initialActions	1	0	5	1	1	3
			loadScripts	813	673	1120	91	882	966
			setupStore	11	5	43	5	12	20
			numNetworkReqs	12	5	77	21	5	74
	Browserify	Power User Home	uiStartup	1884	1562	2499	222	2042	2313
			load	995	884	1463	146	1002	1425
			domContentLoaded	980	876	1456	144	977	1410
			domInteractive	36	16	183	40	30	170
			firstPaint	559	157	1431	368	929	1043
			backgroundConnect	223	200	261	12	229	246
			firstReactRender	82	43	147	19	88	122
			getState	176	128	307	38	197	261
			initialActions	1	0	2	1	1	2
			loadScripts	774	670	1246	143	772	1197
			setupStore	20	10	67	10	25	39
			numNetworkReqs	137	72	303	54	178	243
	Webpack	Standard Home	uiStartup	793	683	986	64	830	936
			load	594	546	785	51	605	730
			domContentLoaded	589	541	779	50	596	725
			domInteractive	22	14	91	15	19	62
			firstPaint	264	70	762	186	281	622
			backgroundConnect	12	5	31	7	17	27
			firstReactRender	29	19	77	8	33	39
			getState	30	13	74	10	35	48
			initialActions	1	0	5	1	1	2
			loadScripts	586	538	771	48	594	717
			setupStore	12	7	21	4	14	18
			numNetworkReqs	12	5	77	21	5	75
	Webpack	Power User Home	uiStartup	1451	1084	2006	229	1623	1952
			load	680	574	1064	123	686	1033
			domContentLoaded	669	568	1052	122	667	1023
			domInteractive	38	16	174	37	31	148
			firstPaint	293	92	1049	195	282	691
			backgroundConnect	15	7	55	7	18	27
			firstReactRender	82	52	115	12	90	100
			getState	156	123	240	26	165	209
			initialActions	1	0	3	1	1	2
			loadScripts	666	566	1037	120	665	1012
			setupStore	23	10	78	16	33	58
			numNetworkReqs	154	69	302	56	198	292
Firefox	Browserify	Standard Home	uiStartup	1290	1100	1588	122	1371	1555
			load	1088	935	1337	95	1145	1269
			domContentLoaded	1087	933	1337	95	1143	1269
			domInteractive	62	30	174	35	83	148
			firstPaint	-	-	-	-	-	-
			backgroundConnect	42	21	149	21	44	84
			firstReactRender	22	18	37	3	22	30
			getState	9	6	46	5	9	17
			initialActions	1	0	3	1	1	2
			loadScripts	1060	917	1311	89	1114	1239
			setupStore	11	5	60	7	10	29
			numNetworkReqs	12	5	68	17	7	61
	Browserify	Power User Home	uiStartup	2707	1869	3670	378	2895	3518
			load	1156	928	1776	186	1190	1618
			domContentLoaded	1155	928	1776	186	1190	1618
			domInteractive	140	32	583	129	144	473
			firstPaint	-	-	-	-	-	-
			backgroundConnect	236	28	982	249	330	798
			firstReactRender	86	47	133	18	93	125
			getState	294	89	1284	280	286	871
			initialActions	3	1	35	4	2	7
			loadScripts	1111	916	1611	169	1138	1529
			setupStore	123	6	775	188	97	740
			numNetworkReqs	101	50	217	41	123	201
	Webpack	Standard Home	uiStartup	1385	1217	1943	134	1427	1634
			load	1175	1045	1453	90	1231	1359
			domContentLoaded	1174	1045	1453	90	1231	1359
			domInteractive	58	25	135	32	82	128
			firstPaint	-	-	-	-	-	-
			backgroundConnect	39	20	227	30	38	106
			firstReactRender	26	20	77	7	27	37
			getState	13	6	139	17	10	43
			initialActions	1	0	2	0	1	2
			loadScripts	1153	1031	1403	85	1204	1300
			setupStore	14	5	205	23	10	33
			numNetworkReqs	12	5	68	16	6	62
	Webpack	Power User Home	uiStartup	2926	2042	3886	417	3118	3777
			load	1376	1075	1958	193	1510	1768
			domContentLoaded	1376	1075	1958	193	1509	1768
			domInteractive	136	28	601	137	139	495
			firstPaint	-	-	-	-	-	-
			backgroundConnect	181	25	921	198	200	628
			firstReactRender	89	47	187	20	99	122
			getState	295	85	1589	302	251	884
			initialActions	4	0	65	7	2	7
			loadScripts	1344	1062	1919	188	1465	1707
			setupStore	105	6	825	164	100	637
			numNetworkReqs	99	68	223	42	95	201

📊 Page Load Benchmark Results

Current Commit: c87eecc | Date: 11/20/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±129ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 724ms (±148ms) 🟢 | historical mean value: 730ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 96ms (±216ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	129ms	998ms	2.29s	1.05s	2.29s
domContentLoaded	724ms	148ms	692ms	2.18s	725ms	2.18s
firstPaint	96ms	216ms	60ms	2.25s	84ms	2.25s
firstContentfulPaint	96ms	216ms	60ms	2.25s	84ms	2.25s
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 53 Bytes (0%)
ui: 2.56 KiB (0.04%)
common: 20 Bytes (0%)

jpuri added 30 commits November 14, 2025 22:26

Fix: backup/restore for batched swaps

986f169

update

f75740a

Merge branch 'main' into dapp_switch_fix

60ed1c4

update

bb5b33e

feat: additing more dapp swap metrics

3551fc4

update

82a4107

Make min amount dynamic value in tooltip

7050926

Merge branch 'main' into tooltip_fix

3381053

update

7f2cfc5

Merge branch 'tooltip_fix' of https://github.com/MetaMask/metamask-ex…

4cb1711

…tension into tooltip_fix

update

e40396c

merge

0c9e63c

Update on dapp-swap ui

d7850f2

update

57c4bcd

update

64fd8fe

Merge branch 'main' into dapp_switch_fix

8c021cf

Merge branch 'dapp_switch_fix' into dapp_swap_metrics

fde6444

update

ad034f3

Updating test cases

af809b3

Adding test coverage

9308918

update

7d645d4

update

e394827

update

c1ea0cb

merge

1360594

Merge branch 'dapp_swap_metrics' of https://github.com/MetaMask/metam…

2670988

…ask-extension into dapp_swap_metrics

Merge branch 'main' into dapp_swap_metrics

f702193

merge

48692de

update

bdb3336

update

6fd10fb

Merge branch 'main' into dapp_swap_metrics

4e947f5

update

502cf4d

cursor bot reviewed Nov 19, 2025

View reviewed changes

...es/confirmations/components/confirm/info/shared/edit-gas-fees-row/edit-gas-fees-row.test.tsx Show resolved Hide resolved

update

f415c8e

cursor bot reviewed Nov 20, 2025

View reviewed changes

ui/pages/confirmations/hooks/transactions/dapp-swap-comparison/useDappSwapComparisonInfo.ts Show resolved Hide resolved

update

5470772

cursor bot reviewed Nov 20, 2025

View reviewed changes

ui/pages/confirmations/hooks/transactions/dapp-swap-comparison/useDappSwapUSDValues.ts Show resolved Hide resolved

jpuri added 2 commits November 20, 2025 10:09

update

157dd41

update

8fae2a4

cursor bot reviewed Nov 20, 2025

View reviewed changes

...confirmations/components/confirm/dapp-swap-comparison-banner/dapp-swap-comparison-banner.tsx Show resolved Hide resolved

update

d70ee9e

Base automatically changed from quotes_fix to main November 20, 2025 07:34

jpuri requested review from a team as code owners November 20, 2025 07:34

jpuri added 3 commits November 20, 2025 13:22

merge

deabf3b

update

53c1dd2

update

c87eecc

chaitanyapotti approved these changes Nov 20, 2025

View reviewed changes

jpuri enabled auto-merge November 20, 2025 08:28

OGPoyraz approved these changes Nov 20, 2025

View reviewed changes

jpuri added this pull request to the merge queue Nov 20, 2025

Merged via the queue into main with commit a616c19 Nov 20, 2025
176 checks passed

jpuri deleted the dapp_swap_context branch November 20, 2025 09:15

github-actions bot locked and limited conversation to collaborators Nov 20, 2025

metamaskbot added the release-13.11.0 Issue or pull request that will be included in release 13.11.0 label Nov 20, 2025

feat: adding context for dapp swap #37980

feat: adding context for dapp swap #37980

Conversation

jpuri commented Nov 19, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

Uh oh!

metamaskbot commented Nov 19, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

metamaskbot commented Nov 20, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Nov 20, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 20, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

chaitanyapotti left a comment

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Nov 20, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jpuri commented Nov 19, 2025 •

edited by cursor bot

Loading