Skip to content

chore: Bump network-controller to v26 (+ dependencies) #37966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 26 commits into
base: main
Choose a base branch
from
Draft

chore: Bump network-controller to v26 (+ dependencies) #37966

wants to merge 26 commits into from
+2,721 −458

Conversation

@mcmire
Copy link
Contributor

@mcmire mcmire commented Nov 19, 2025 •
edited
Loading

Description

Open in GitHub Codespaces

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-core-platform Core Platform team label Nov 19, 2025
@mcmire
Copy link
Contributor Author

mcmire commented Nov 19, 2025

@metamaskbot update-policies

@mcmire mcmire changed the title Bump network-controller to v26 (+ dependencies) chore: Bump network-controller to v26 (+ dependencies) Nov 19, 2025
@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 19, 2025

Builds ready [03ff141]
📊 Page Load Benchmark Results

Current Commit: 03ff141 | Date: 11/19/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±71ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 727ms (±69ms) 🟢 | historical mean value: 722ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 75ms (±11ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 71ms 997ms 1.31s 1.26s 1.31s
domContentLoaded 727ms 69ms 690ms 991ms 931ms 991ms
firstPaint 75ms 11ms 56ms 164ms 84ms 164ms
firstContentfulPaint 75ms 11ms 56ms 164ms 84ms 164ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 289.47 KiB (6.21%)
  • ui: 253 Bytes (0%)
  • common: 316.01 KiB (3.61%)

@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 19, 2025

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 19, 2025 •
edited
Loading

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations (5 files, +88 -44)
  • 📁 app/
    • 📁 scripts/
      • 📁 lib/
        • 📁 signature/
          • 📄 util.test.ts +16 -9
          • 📄 util.ts +39 -19
        • 📁 transaction/
          • 📄 metrics.test.ts +1 -1
          • 📄 util.test.ts +18 -8
          • 📄 util.ts +14 -7
🧩 @MetaMask/extension-devs (6 files, +2147 -161)
  • 📁 lavamoat/
    • 📁 browserify/
      • 📁 beta/
        • 📄 policy.json +416 -28
      • 📁 experimental/
        • 📄 policy.json +416 -28
      • 📁 flask/
        • 📄 policy.json +416 -28
      • 📁 main/
        • 📄 policy.json +416 -28
    • 📁 webpack/
      • 📁 mv2/
        • 📄 policy.json +368 -31
      • 📁 mv3/
        • 📄 policy.json +115 -18
🔒 @MetaMask/extension-security-team (1 files, +1 -1)
  • 📁 .github/
    • 📄 CODEOWNERS +1 -1
📜 @MetaMask/policy-reviewers (6 files, +2147 -161)
  • 📁 lavamoat/
    • 📁 browserify/
      • 📁 beta/
        • 📄 policy.json +416 -28
      • 📁 experimental/
        • 📄 policy.json +416 -28
      • 📁 flask/
        • 📄 policy.json +416 -28
      • 📁 main/
        • 📄 policy.json +416 -28
    • 📁 webpack/
      • 📁 mv2/
        • 📄 policy.json +368 -31
      • 📁 mv3/
        • 📄 policy.json +115 -18

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.

🧪 @MetaMask/qa (1 files, +1 -0)
  • 📁 test/
    • 📁 e2e/
      • 📁 tests/
        • 📁 settings/
          • 📄 state-logs-helpers.ts +1 -0
🔗 @MetaMask/supply-chain (6 files, +2147 -161)
  • 📁 lavamoat/
    • 📁 browserify/
      • 📁 beta/
        • 📄 policy.json +416 -28
      • 📁 experimental/
        • 📄 policy.json +416 -28
      • 📁 flask/
        • 📄 policy.json +416 -28
      • 📁 main/
        • 📄 policy.json +416 -28
    • 📁 webpack/
      • 📁 mv2/
        • 📄 policy.json +368 -31
      • 📁 mv3/
        • 📄 policy.json +115 -18
🔄 @MetaMask/swaps-engineers (1 files, +2 -2)
  • 📁 app/
    • 📁 scripts/
      • 📁 controllers/
        • 📁 swaps/
          • 📄 swaps.test.ts +2 -2
👨‍🔧 @MetaMask/wallet-integrations (5 files, +239 -198)
  • 📁 app/
    • 📁 scripts/
      • 📁 lib/
        • 📁 middleware/
          • 📄 pending.js +0 -35
          • 📄 pending.test.js +0 -118
          • 📄 pending.test.ts +161 -0
          • 📄 pending.ts +78 -0
          • 📄 createMetamaskMiddleware.js +0 -45

@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 19, 2025

❌ test-e2e-chrome-api-specs failed. View the html report here.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 19, 2025

❌ test-e2e-chrome-api-specs-multichain failed. View the html report here.

@github-actions github-actions bot added size-S and removed size-XS labels Nov 19, 2025
@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 19, 2025

❌ test-e2e-chrome-api-specs-multichain failed. View the html report here.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 19, 2025

❌ test-e2e-chrome-api-specs failed. View the html report here.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 19, 2025

Builds ready [b0e851c]
📊 Page Load Benchmark Results

Current Commit: b0e851c | Date: 11/19/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±124ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 737ms (±150ms) 🟢 | historical mean value: 722ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 89ms (±125ms) 🟢 | historical mean value: 80ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 124ms 1.02s 2.25s 1.07s 2.25s
domContentLoaded 737ms 150ms 702ms 2.21s 744ms 2.21s
firstPaint 89ms 125ms 60ms 1.34s 84ms 1.34s
firstContentfulPaint 89ms 125ms 60ms 1.34s 84ms 1.34s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 289.47 KiB (6.21%)
  • ui: 253 Bytes (0%)
  • common: 316.01 KiB (3.61%)

@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 19, 2025

Builds ready [1343df3]
📊 Page Load Benchmark Results

Current Commit: 1343df3 | Date: 11/19/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.07s (±71ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 749ms (±68ms) 🟢 | historical mean value: 722ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 80ms (±12ms) 🟢 | historical mean value: 80ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.07s 71ms 1.03s 1.34s 1.29s 1.34s
domContentLoaded 749ms 68ms 709ms 1.01s 959ms 1.01s
firstPaint 80ms 12ms 68ms 188ms 92ms 188ms
firstContentfulPaint 80ms 12ms 68ms 188ms 92ms 188ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 284.2 KiB (6.09%)
  • ui: 8.99 KiB (0.12%)
  • common: 253.18 KiB (2.89%)

@mcmire
Copy link
Contributor Author

mcmire commented Nov 19, 2025

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 19, 2025

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 19, 2025

❌ test-e2e-chrome-api-specs failed. View the html report here.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 19, 2025

❌ test-e2e-chrome-api-specs-multichain failed. View the html report here.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 19, 2025

Builds ready [2f07135]
UI Startup Metrics (1240 ± 92 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1240108514509213131402
load105489812608811301203
domContentLoaded104789612558811201196
domInteractive231575162174
firstPaint53081120341410251175
backgroundConnect21719725811223240
firstReactRender28195983245
getState321495123555
initialActions103112
loadScripts837687103987912974
setupStore1244461228
numNetworkReqs1367419673
BrowserifyPower User HomeuiStartup19921603277826221512470
load1064917184117310741524
domContentLoaded1049906182817210521514
domInteractive41172134234160
firstPaint60610318504329971447
backgroundConnect23621327814244265
firstReactRender87492372193111
getState18714636445198282
initialActions105112
loadScripts82969215941708351282
setupStore21966122746
numNetworkReqs966820130106172
WebpackStandard HomeuiStartup8387061172888631051
load59854689977607824
domContentLoaded59153888173602804
domInteractive181160121453
firstPaint18860882194183731
backgroundConnect241191172278
firstReactRender311981103741
getState19123952226
initialActions101011
loadScripts58853687271600791
setupStore1162631317
numNetworkReqs1467620872
WebpackPower User HomeuiStartup13371175241820614511732
load66057412491376491008
domContentLoaded6415621176127629960
domInteractive30132204019141
firstPaint290611151278539941
backgroundConnect47123614363116
firstReactRender754198128291
getState15410223218162190
initialActions101011
loadScripts6385601165125626951
setupStore17791172958
numNetworkReqs1297124547175237
FirefoxBrowserifyStandard HomeuiStartup13091135173211913841565
load109996313458811711254
domContentLoaded109996313448811711254
domInteractive68252504485138
firstPaint------
backgroundConnect4422151244893
firstReactRender23184762338
getState136201241019
initialActions102022
loadScripts107194713127811171205
setupStore12669101029
numNetworkReqs1267615857
BrowserifyPower User HomeuiStartup26412072368031828623364
load1166955163117912131546
domContentLoaded1166955163117912131546
domInteractive12930539128131518
firstPaint------
backgroundConnect18023941206198673
firstReactRender82361371992117
getState23375864242178832
initialActions3048627
loadScripts1132935161417711531522
setupStore1216785188100672
numNetworkReqs96492114194197
WebpackStandard HomeuiStartup14711323195512515211735
load1253108115269813061446
domContentLoaded1253108115199813061446
domInteractive76292444599165
firstPaint------
backgroundConnect41211692343100
firstReactRender302177113269
getState13689131248
initialActions103122
loadScripts1225105414909212821395
setupStore14677131146
numNetworkReqs1366717763
WebpackPower User HomeuiStartup29452101376834631343582
load14291114205620515821821
domContentLoaded14291114205520515821820
domInteractive14529752144160543
firstPaint------
backgroundConnect17427861193192630
firstReactRender88402232697140
getState27983891269429841
initialActions217123
loadScripts13991099203420215411794
setupStore1286769195117697
numNetworkReqs97632214592215
📊 Page Load Benchmark Results

Current Commit: 2f07135 | Date: 11/19/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.17s (±92ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 807ms (±96ms) 🟢 | historical mean value: 727ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 104ms (±118ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.17s 92ms 1.03s 1.55s 1.40s 1.55s
domContentLoaded 807ms 96ms 702ms 1.21s 1.11s 1.21s
firstPaint 104ms 118ms 68ms 1.28s 112ms 1.28s
firstContentfulPaint 104ms 118ms 68ms 1.28s 112ms 1.28s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 284.41 KiB (6.1%)
  • ui: -451.01 KiB (-6.06%)
  • common: 253.91 KiB (2.9%)

@mcmire
Copy link
Contributor Author

mcmire commented Nov 19, 2025

@metamaskbot update-policies

@github-actions github-actions bot added size-L and removed size-S labels Nov 19, 2025
@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 19, 2025

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 19, 2025

Builds ready [38ad71a]
UI Startup Metrics (1230 ± 91 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1230106814439112861408
load104590612658611041195
domContentLoaded104090112588510991187
domInteractive241493182273
firstPaint51199127240510141184
backgroundConnect21519525811221237
firstReactRender29194983346
getState341665113858
initialActions108113
loadScripts831688106085893988
setupStore1172941118
numNetworkReqs1367620673
BrowserifyPower User HomeuiStartup19001601247023620792393
load1021902155515310461457
domContentLoaded1004896153514810171434
domInteractive36162094030156
firstPaint5449115584029391407
backgroundConnect23220827114239261
firstReactRender82481441792119
getState18514237949195302
initialActions103112
loadScripts79068713191488021223
setupStore20668122841
numNetworkReqs956819729105170
WebpackStandard HomeuiStartup8637531104779081030
load63758383160647805
domContentLoaded63257882259643799
domInteractive2514107192280
firstPaint229102802157216630
backgroundConnect1163471129
firstReactRender3322260233441
getState311562113848
initialActions103113
loadScripts62957681057641788
setupStore1262341519
numNetworkReqs1367619668
WebpackPower User HomeuiStartup14531205231221915941902
load6785911330125688988
domContentLoaded6675841320124672980
domInteractive37161883729152
firstPaint260991050183265651
backgroundConnect1584671829
firstReactRender82461311492103
getState15513227529159221
initialActions104112
loadScripts6645821309122670971
setupStore241067143449
numNetworkReqs1346726750171257
FirefoxBrowserifyStandard HomeuiStartup12351066169511012841441
load103691012417810881175
domContentLoaded103691012417910881175
domInteractive63282343783133
firstPaint------
backgroundConnect4123225274384
firstReactRender23184572343
getState106869921
initialActions102012
loadScripts101089411877010641149
setupStore12577121036
numNetworkReqs1267215860
BrowserifyPower User HomeuiStartup26231933345834427923368
load1163967179018012261534
domContentLoaded1163967178918012261534
domInteractive14330580129154476
firstPaint------
backgroundConnect22224955245322729
firstReactRender83381612092123
getState22182870221185819
initialActions2027424
loadScripts1124942175917511421516
setupStore1438828219130779
numNetworkReqs96612154291202
WebpackStandard HomeuiStartup14481247199212314941721
load1235108014909412891429
domContentLoaded1234108014909412891429
domInteractive63272314080131
firstPaint------
backgroundConnect44201842545105
firstReactRender26193943034
getState136190221044
initialActions107112
loadScripts1210106314318812641363
setupStore12564101137
numNetworkReqs1366717764
WebpackPower User HomeuiStartup28592037365834130333555
load13991133195619215851731
domContentLoaded13991133195619315841731
domInteractive13130645130150467
firstPaint------
backgroundConnect16525676170192573
firstReactRender893824627103129
getState27081885273217852
initialActions208227
loadScripts13591115187619215421698
setupStore1166821166111505
numNetworkReqs97592324693214
📊 Page Load Benchmark Results

Current Commit: 38ad71a | Date: 11/19/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±50ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 738ms (±48ms) 🟢 | historical mean value: 730ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±13ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 50ms 1.01s 1.31s 1.11s 1.31s
domContentLoaded 738ms 48ms 696ms 997ms 788ms 997ms
firstPaint 78ms 13ms 60ms 196ms 84ms 196ms
firstContentfulPaint 78ms 13ms 60ms 196ms 84ms 196ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 284.37 KiB (6.1%)
  • ui: 8.89 KiB (0.13%)
  • common: 253.14 KiB (2.89%)

@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 20, 2025

Builds ready [2739743]
UI Startup Metrics (1241 ± 103 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12411041151210313151400
load105988512529611351204
domContentLoaded105288212449611251195
domInteractive2314105162065
firstPaint657166125843411001202
backgroundConnect21218333119219241
firstReactRender3019136153353
getState331778123756
initialActions105113
loadScripts849677102194926996
setupStore1253451324
numNetworkReqs1367720674
BrowserifyPower User HomeuiStartup19201562281326220802492
load1021907156615710281493
domContentLoaded1006898155115610021483
domInteractive37172003929151
firstPaint60610415794039671415
backgroundConnect23020927611234250
firstReactRender84511491988129
getState18413835148200299
initialActions102012
loadScripts79368613361547891264
setupStore20105792642
numNetworkReqs976919631103183
WebpackStandard HomeuiStartup836736124884881994
load62957498167632792
domContentLoaded62457197067629787
domInteractive2514136232183
firstPaint24787787184216673
backgroundConnect1164271029
firstReactRender3121121133440
getState321556114151
initialActions106112
loadScripts62156996064627778
setupStore1273141420
numNetworkReqs1367619669
WebpackPower User HomeuiStartup14341204208320715341866
load6555721059117656988
domContentLoaded6455641048115643978
domInteractive35161653330127
firstPaint334951002228577758
backgroundConnect1575371726
firstReactRender81471111390102
getState16114224823162214
initialActions104113
loadScripts6425621037113641969
setupStore22959133348
numNetworkReqs1347127548172239
FirefoxBrowserifyStandard HomeuiStartup12361055161011412981458
load104387712888211001199
domContentLoaded104287712888211001199
domInteractive67282324285166
firstPaint------
backgroundConnect3921278293979
firstReactRender2217102102240
getState96657917
initialActions102112
loadScripts101886012577510741153
setupStore12517819933
numNetworkReqs1266615861
BrowserifyPower User HomeuiStartup25751799367137627063488
load1131927175118811671563
domContentLoaded1131927175118811661563
domInteractive13731678137134507
firstPaint------
backgroundConnect20521982233295748
firstReactRender83371371993118
getState19879893200178824
initialActions3028427
loadScripts1093911160317511091486
setupStore1245792204117756
numNetworkReqs96582204391212
WebpackStandard HomeuiStartup14401247186212614851736
load1227107615089412781404
domContentLoaded1227107515089512771404
domInteractive63282304080137
firstPaint------
backgroundConnect4017130204294
firstReactRender27227063037
getState12689111235
initialActions104112
loadScripts1203106014838812531358
setupStore1158111930
numNetworkReqs1366617764
WebpackPower User HomeuiStartup28201986384038630303643
load14091098193818014791762
domContentLoaded14091098193818014791761
domInteractive13728533121153452
firstPaint------
backgroundConnect18724876196196655
firstReactRender90442422796132
getState28983890279397852
initialActions3035528
loadScripts13751083184917414321734
setupStore94779115689607
numNetworkReqs965922741100203
📊 Page Load Benchmark Results

Current Commit: 2739743 | Date: 11/20/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±43ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 719ms (±39ms) 🟢 | historical mean value: 730ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±13ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 43ms 1.00s 1.34s 1.06s 1.34s
domContentLoaded 719ms 39ms 694ms 998ms 748ms 998ms
firstPaint 77ms 13ms 60ms 192ms 88ms 192ms
firstContentfulPaint 77ms 13ms 60ms 192ms 88ms 192ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 284.37 KiB (6.1%)
  • ui: 8.89 KiB (0.13%)
  • common: 253.14 KiB (2.89%)

@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 20, 2025

Builds ready [6956504]
UI Startup Metrics (1236 ± 101 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12361060157110113161399
load105890513299111301208
domContentLoaded105290013239011241200
domInteractive241483162174
firstPaint60399133844310761183
backgroundConnect21519726311218238
firstReactRender28195683342
getState321877113758
initialActions106112
loadScripts845696110189916983
setupStore1172831118
numNetworkReqs1257720573
BrowserifyPower User HomeuiStartup19241583255122421212292
load1023912152012810361385
domContentLoaded1007906150912610091374
domInteractive34172213428131
firstPaint5409314893999581349
backgroundConnect23321327813240256
firstReactRender85531511792125
getState17513029439199254
initialActions1010112
loadScripts79169412861267951164
setupStore211051102842
numNetworkReqs966918426109170
WebpackStandard HomeuiStartup8107281077778421000
load61856084963621790
domContentLoaded61355784563618784
domInteractive2514147212174
firstPaint24988814174263620
backgroundConnect1163371428
firstReactRender28206063237
getState3014104133847
initialActions103111
loadScripts61055583661616774
setupStore1262841420
numNetworkReqs1257720573
WebpackPower User HomeuiStartup19881525346137222622711
load93072620092119471418
domContentLoaded91471219932099121407
domInteractive52222795246195
firstPaint3351161663251328886
backgroundConnect249114172961
firstReactRender1106414116122136
getState20615434948233315
initialActions105122
loadScripts91070919792069091392
setupStore2812102173761
numNetworkReqs986919433105190
FirefoxBrowserifyStandard HomeuiStartup12141064179412512591495
load102191712607910721191
domContentLoaded102091712607910711191
domInteractive56291713176133
firstPaint------
backgroundConnect3821166254083
firstReactRender21165162135
getState1168812940
initialActions103112
loadScripts99890412057110431159
setupStore13520323944
numNetworkReqs1256717663
BrowserifyPower User HomeuiStartup27111792385241529703591
load1215980175119813471612
domContentLoaded1215973175019813471612
domInteractive14732590140156544
firstPaint------
backgroundConnect211241000227257726
firstReactRender87501351995123
getState23576874227203845
initialActions218227
loadScripts1169958171919212031576
setupStore1486863220105785
numNetworkReqs99682244492216
WebpackStandard HomeuiStartup14411280184913114721714
load1222108715409512741421
domContentLoaded1221108715409512741420
domInteractive65302314281169
firstPaint------
backgroundConnect3721149174168
firstReactRender27207162939
getState1066371119
initialActions102122
loadScripts1200107114879212551396
setupStore135186201141
numNetworkReqs1257218665
WebpackPower User HomeuiStartup29112272366334331093551
load13761120187719114781756
domContentLoaded13761120187719114771756
domInteractive13227560123137450
firstPaint------
backgroundConnect18926781214212723
firstReactRender87401712298122
getState291851540300220895
initialActions5159958
loadScripts13451103185318914531726
setupStore1255768192114672
numNetworkReqs99652294594218
📊 Page Load Benchmark Results

Current Commit: 6956504 | Date: 11/20/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.06s (±103ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 746ms (±116ms) 🟢 | historical mean value: 729ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 92ms (±169ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.06s 103ms 1.02s 1.84s 1.30s 1.84s
domContentLoaded 746ms 116ms 702ms 1.71s 955ms 1.71s
firstPaint 92ms 169ms 56ms 1.78s 88ms 1.78s
firstContentfulPaint 92ms 169ms 56ms 1.78s 88ms 1.78s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 284.18 KiB (6.09%)
  • ui: 11.56 KiB (0.17%)
  • common: 254.45 KiB (2.91%)

@mcmire
Copy link
Contributor Author

mcmire commented Nov 21, 2025

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 21, 2025

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 21, 2025

Builds ready [445baec]
UI Startup Metrics (1219 ± 89 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1219105014098912811368
load103590512298310971168
domContentLoaded102988212258210901163
domInteractive231488162065
firstPaint5047411893969781163
backgroundConnect21419724710217238
firstReactRender30195883646
getState321572113856
initialActions107112
loadScripts823680100982884958
setupStore1172441320
numNetworkReqs1257820573
BrowserifyPower User HomeuiStartup19361622253523421302399
load1042898159514310741435
domContentLoaded1026889156314210391425
domInteractive40182024433171
firstPaint5949716034079821345
backgroundConnect24021429516248269
firstReactRender86501562094135
getState17813132740194269
initialActions107112
loadScripts80468313391418151196
setupStore19756112649
numNetworkReqs946819731105180
WebpackStandard HomeuiStartup8507461212908661037
load63658489269639810
domContentLoaded63257888368635805
domInteractive2515101182382
firstPaint23576779168224622
backgroundConnect1264081430
firstReactRender30214053439
getState311383123949
initialActions104112
loadScripts62957587366633795
setupStore1263851421
numNetworkReqs1257719570
WebpackPower User HomeuiStartup14111024239024215471956
load66357213751406561026
domContentLoaded65356513671386411007
domInteractive34161723529145
firstPaint297851028226442712
backgroundConnect1473771829
firstReactRender7849106118694
getState15512127133159242
initialActions104112
loadScripts6505631356135639987
setupStore21652123144
numNetworkReqs1526830457186301
FirefoxBrowserifyStandard HomeuiStartup12521063161611313041508
load105591612697811171192
domContentLoaded105491112697811161192
domInteractive60311583283133
firstPaint------
backgroundConnect4221151224687
firstReactRender21175042125
getState11614117919
initialActions103112
loadScripts102890212067010701169
setupStore12515517927
numNetworkReqs1156815654
BrowserifyPower User HomeuiStartup26991908379338428933501
load1189948173118112711549
domContentLoaded1189948173118112701548
domInteractive14833643131162469
firstPaint------
backgroundConnect232271006265284863
firstReactRender87441642195134
getState23776862244188839
initialActions3140437
loadScripts1144930159216612091508
setupStore99674214697524
numNetworkReqs96642244490217
WebpackStandard HomeuiStartup14671257200814315201732
load12531090158610313101449
domContentLoaded12531090158610313091449
domInteractive62272013781134
firstPaint------
backgroundConnect41171232342109
firstReactRender26203952937
getState1062841118
initialActions102112
loadScripts1226107115169212861398
setupStore145199211138
numNetworkReqs1256617664
WebpackPower User HomeuiStartup28342211380033329903620
load14291134204019015141872
domContentLoaded14291134203919015141872
domInteractive13933674134146531
firstPaint------
backgroundConnect17230877178205605
firstReactRender87421852295123
getState23176869243178837
initialActions507011333
loadScripts13941116199018014631780
setupStore1499768222123738
numNetworkReqs96602204590215
📊 Page Load Benchmark Results

Current Commit: 445baec | Date: 11/21/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±52ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 732ms (±50ms) 🟢 | historical mean value: 732ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±12ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 52ms 1.02s 1.32s 1.09s 1.32s
domContentLoaded 732ms 50ms 705ms 1.01s 772ms 1.01s
firstPaint 78ms 12ms 64ms 180ms 92ms 180ms
firstContentfulPaint 78ms 12ms 64ms 180ms 92ms 180ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 345.06 KiB (7.39%)
  • ui: 8.9 KiB (0.13%)
  • common: 298.8 KiB (3.41%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size-L team-core-platform Core Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mcmire @metamaskbot @rekmarks