chore: update `CODEOWNERS.md` with `@metamask/wallet-integrations` team ownership #36577

adonesky1 · 2025-10-03T19:32:20Z

There are a ton of files/folders here that have been owned by Wallet Integrations Team (formerly Wallet API Platform team) where we have not been pinged for reviews because of missing CODEOWNER entries. This is my fault. Its time to correct it.

Note

Updates CODEOWNERS to add @MetaMask/wallet-integrations ownership across middleware/libs and E2E benchmarks/tests, replacing prior wallet-api-platform entries.

CODEOWNERS updates:
- Add @MetaMask/wallet-integrations ownership for:
  - app/scripts/lib/rpc-method-middleware
  - shared/lib/caip25-caveat-merger.ts
  - test/e2e/page-objects/benchmark
  - test/e2e/playwright/benchmark
  - test/e2e/flask/multichain-api
  - app/scripts/lib/middleware/
  - app/scripts/lib/createRPCMethodTrackingMiddleware.js
  - app/scripts/lib/createMetamaskMiddleware.js
  - app/scripts/lib/createOnboardingMiddleware.js
  - app/scripts/lib/createMetaRPCHandler.js
  - app/scripts/lib/createEvmMethodsToNonEvmAccountReqFilterMiddleware.ts
  - app/scripts/lib/createHyperliquidReferralMiddleware.ts
  - app/scripts/lib/metaRPCClientFactory.ts
  - app/scripts/lib/createOriginThrottlingMiddleware.ts
  - app/scripts/lib/createMainFrameOriginMiddleware.ts
  - app/scripts/lib/createTracingMiddleware.ts
- Replace @MetaMask/wallet-api-platform-engineers ownership of benchmark paths with @MetaMask/wallet-integrations.

^{Written by Cursor Bugbot for commit b255573. This will update automatically on new commits. Configure here.}

github-actions · 2025-10-03T19:32:30Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-10-03T19:34:31Z

✨ Files requiring CODEOWNER review ✨

🔒 @MetaMask/extension-security-team (1 files, +18 -3)

📁 .github/
- 📄 CODEOWNERS +18 -3

metamaskbot · 2025-10-03T19:58:37Z

📊 Page Load Benchmark Results

Current Commit: 94a176b | Date: 10/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±70ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 741ms (±68ms) 🟢 | historical mean value: 738ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 78ms (±12ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	70ms	1.02s	1.32s	1.28s	1.32s
domContentLoaded	741ms	68ms	703ms	999ms	950ms	999ms
firstPaint	78ms	12ms	60ms	180ms	88ms	180ms
firstContentfulPaint	78ms	12ms	60ms	180ms	88ms	180ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-03T19:58:45Z

Builds ready [94a176b]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1229 ± 73 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1229	1090	1460	73	1277	1351
			load	1063	958	1261	70	1107	1186
			domContentLoaded	1055	952	1241	70	1101	1180
			domInteractive	17	13	61	8	16	43
			firstPaint	657	73	1267	432	1068	1164
			backgroundConnect	253	239	287	8	257	274
			firstReactRender	23	17	54	6	24	37
			getState	12	5	32	6	14	27
			initialActions	5	0	32	5	5	13
			loadScripts	809	708	988	69	858	933
			setupStore	9	5	27	4	10	20
	Webpack	Home	uiStartup	1870	1565	2257	175	2001	2196
			load	1533	1329	1854	122	1630	1778
			domContentLoaded	1518	1317	1847	122	1611	1735
			domInteractive	18	11	113	18	13	57
			firstPaint	282	54	1775	443	186	1496
			backgroundConnect	33	16	137	16	39	54
			firstReactRender	50	19	137	20	57	97
			getState	13	5	44	7	14	26
			initialActions	3	0	29	5	3	14
			loadScripts	1514	1313	1846	122	1607	1734
			setupStore	12	4	37	6	14	25
Firefox	Browserify	Home	uiStartup	1427	1235	1843	113	1476	1661
			load	1227	1081	1420	79	1289	1370
			domContentLoaded	1227	1081	1420	79	1288	1369
			domInteractive	104	34	303	53	108	257
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	29	18	62	8	33	41
			firstReactRender	29	24	49	4	30	37
			getState	9	3	89	12	7	46
			initialActions	6	1	196	20	4	10
			loadScripts	1205	1063	1395	77	1267	1340
			setupStore	9	5	51	8	8	30
	Webpack	Home	uiStartup	1573	1353	2128	140	1604	1948
			load	1366	1204	1695	96	1415	1556
			domContentLoaded	1366	1204	1695	96	1414	1556
			domInteractive	107	33	385	76	106	354
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	35	18	117	18	39	86
			firstReactRender	36	25	80	13	35	76
			getState	9	3	71	12	7	48
			initialActions	5	1	175	17	3	12
			loadScripts	1338	1187	1670	91	1383	1502
			setupStore	15	5	207	28	9	57

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 20.75 KiB (0.46%)
ui: 9.65 KiB (0.15%)
common: 11.53 KiB (0.14%)

metamaskbot · 2025-10-03T21:08:14Z

📊 Page Load Benchmark Results

Current Commit: c9b7fe8 | Date: 10/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±70ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 739ms (±68ms) 🟢 | historical mean value: 738ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±11ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	70ms	1.02s	1.33s	1.26s	1.33s
domContentLoaded	739ms	68ms	703ms	1.01s	939ms	1.01s
firstPaint	77ms	11ms	60ms	172ms	88ms	172ms
firstContentfulPaint	77ms	11ms	60ms	172ms	88ms	172ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-03T21:08:28Z

Builds ready [c9b7fe8]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1238 ± 71 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1238	1084	1481	71	1281	1361
			load	1065	943	1287	66	1099	1183
			domContentLoaded	1055	936	1278	67	1092	1174
			domInteractive	18	13	129	12	17	33
			firstPaint	652	72	1213	432	1063	1153
			backgroundConnect	258	240	365	15	261	285
			firstReactRender	25	14	50	7	28	38
			getState	12	5	40	6	15	27
			initialActions	6	0	46	8	6	23
			loadScripts	807	690	1009	64	837	931
			setupStore	10	6	23	4	11	19
	Webpack	Home	uiStartup	1808	1529	2236	174	1947	2123
			load	1500	1313	1870	109	1568	1736
			domContentLoaded	1487	1298	1865	109	1555	1729
			domInteractive	17	11	88	13	13	48
			firstPaint	275	54	1740	419	190	1503
			backgroundConnect	31	16	111	14	36	59
			firstReactRender	44	19	147	21	53	84
			getState	13	4	150	15	14	22
			initialActions	4	0	99	11	3	19
			loadScripts	1483	1294	1863	108	1551	1721
			setupStore	11	4	38	6	12	26
Firefox	Browserify	Home	uiStartup	1427	1237	2049	141	1483	1674
			load	1224	1082	1464	87	1296	1371
			domContentLoaded	1224	1080	1464	87	1296	1371
			domInteractive	109	35	348	63	115	276
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	30	20	152	14	33	44
			firstReactRender	28	24	40	4	30	37
			getState	9	3	184	19	7	25
			initialActions	5	1	202	20	4	9
			loadScripts	1202	1063	1443	85	1274	1348
			setupStore	12	5	156	21	8	24
	Webpack	Home	uiStartup	1592	1369	2383	144	1631	1880
			load	1370	1209	1936	101	1409	1537
			domContentLoaded	1370	1209	1935	101	1408	1537
			domInteractive	103	31	408	71	104	354
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	36	21	197	25	37	85
			firstReactRender	36	26	87	13	37	77
			getState	11	3	153	20	7	50
			initialActions	4	1	52	5	4	10
			loadScripts	1343	1193	1785	91	1382	1505
			setupStore	15	5	79	16	11	51

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 20.75 KiB (0.46%)
ui: 9.65 KiB (0.15%)
common: 11.53 KiB (0.14%)

.github/CODEOWNERS

Gudahtt · 2025-10-08T20:12:29Z

.github/CODEOWNERS

+app/scripts/lib/createHyperliquidReferralMiddleware.ts                @MetaMask/wallet-integrations
+app/scripts/lib/metaRPCClientFactory.ts                               @MetaMask/wallet-integrations
+app/scripts/lib/middleware/                                           @MetaMask/wallet-integrations
+app/scripts/lib/stream-utils.js                                       @MetaMask/wallet-integrations


What was the reasoning for including this one? This seems more related to the streams between platforms, which I know your team works with often enough, but it's more of an extension platform responsibility

Happy to cede this to extension platform! Should I add an entry for it for them in this PR or leave that out altogether in your opinion?

Fine to leave it out I think. Shared code is a good default

.github/CODEOWNERS

metamaskbot · 2025-10-08T21:15:08Z

📊 Page Load Benchmark Results

Current Commit: b255573 | Date: 10/8/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±142ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 749ms (±146ms) 🟢 | historical mean value: 736ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 87ms (±114ms) 🟢 | historical mean value: 79ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	142ms	1.01s	2.31s	1.28s	2.31s
domContentLoaded	749ms	146ms	702ms	2.05s	961ms	2.05s
firstPaint	87ms	114ms	60ms	1.22s	84ms	1.22s
firstContentfulPaint	87ms	114ms	60ms	1.22s	84ms	1.22s
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-08T21:15:20Z

Builds ready [b255573]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1237 ± 79 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1237	1103	1474	79	1284	1379
			load	1075	955	1278	75	1122	1209
			domContentLoaded	1070	952	1273	74	1118	1203
			domInteractive	20	13	184	21	16	39
			firstPaint	598	75	1281	434	1070	1187
			backgroundConnect	249	234	282	7	253	261
			firstReactRender	23	17	48	5	25	34
			getState	12	5	29	6	15	24
			initialActions	5	0	26	5	6	15
			loadScripts	826	712	1029	73	875	960
			setupStore	9	5	25	4	10	18
	Webpack	Home	uiStartup	1811	1535	2290	161	1936	2122
			load	1501	1362	1793	94	1568	1685
			domContentLoaded	1488	1354	1787	91	1553	1677
			domInteractive	16	11	71	12	14	49
			firstPaint	268	57	1690	418	187	1547
			backgroundConnect	32	14	177	19	37	59
			firstReactRender	46	19	171	26	51	97
			getState	12	5	152	15	12	22
			initialActions	4	0	152	16	2	13
			loadScripts	1484	1351	1786	90	1549	1672
			setupStore	13	4	154	16	13	26
Firefox	Browserify	Home	uiStartup	1402	1189	1939	140	1446	1690
			load	1204	1037	1481	88	1272	1343
			domContentLoaded	1203	1037	1480	88	1271	1343
			domInteractive	106	32	272	55	110	247
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	28	19	72	8	32	43
			firstReactRender	29	24	62	7	30	49
			getState	9	2	139	17	6	28
			initialActions	6	0	192	26	2	17
			loadScripts	1183	1021	1453	87	1252	1324
			setupStore	10	3	107	14	7	43
	Webpack	Home	uiStartup	1581	1391	2944	190	1619	1926
			load	1375	1241	2724	159	1405	1550
			domContentLoaded	1375	1240	2724	159	1405	1549
			domInteractive	117	30	1551	161	108	369
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	34	17	113	16	36	74
			firstReactRender	34	25	119	15	34	77
			getState	8	3	58	10	6	33
			initialActions	4	0	124	13	2	12
			loadScripts	1349	1220	2703	157	1379	1523
			setupStore	14	4	145	25	7	61

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 36.07 KiB (0.8%)
ui: -78.96 KiB (-1.21%)
common: 21.45 KiB (0.26%)

Gudahtt

LGTM!

update wallet-integrations team codeownership

94a176b

adonesky1 requested a review from a team as a code owner October 3, 2025 19:32

metamaskbot added team-wallet-api-platform-deprecated DEPRECATED: please use "team-wallet-integrations" instead INVALID-PR-TEMPLATE PR's body doesn't match template labels Oct 3, 2025

github-actions bot added the size-S label Oct 3, 2025

This comment was marked as outdated.

Sign in to view

missing entry

c9b7fe8

alfredomontes37826-ux approved these changes Oct 4, 2025

View reviewed changes

Gudahtt reviewed Oct 8, 2025

View reviewed changes

.github/CODEOWNERS Outdated Show resolved Hide resolved

Gudahtt reviewed Oct 8, 2025

View reviewed changes

.github/CODEOWNERS Outdated Show resolved Hide resolved

cleanup invalid entries

b255573

Gudahtt approved these changes Oct 9, 2025

View reviewed changes

jiexi approved these changes Oct 13, 2025

View reviewed changes

adonesky1 added this pull request to the merge queue Oct 13, 2025

Merged via the queue into main with commit 7f6ba73 Oct 13, 2025
170 checks passed

adonesky1 deleted the ad/update-wallet-integrations-team-codeownership branch October 13, 2025 18:29

github-actions bot locked and limited conversation to collaborators Oct 13, 2025

metamaskbot added the release-13.6.0 Issue or pull request that will be included in release 13.6.0 label Oct 13, 2025

Uh oh!

chore: update CODEOWNERS.md with @metamask/wallet-integrations team ownership #36577

chore: update CODEOWNERS.md with @metamask/wallet-integrations team ownership #36577

Conversation

adonesky1 commented Oct 3, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 3, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Oct 3, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 3, 2025

Uh oh!

metamaskbot commented Oct 3, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 3, 2025

Uh oh!

Uh oh!

Gudahtt Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

adonesky1 Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Gudahtt Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

metamaskbot commented Oct 8, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 8, 2025

Uh oh!

Gudahtt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

chore: update `CODEOWNERS.md` with `@metamask/wallet-integrations` team ownership #36577

chore: update `CODEOWNERS.md` with `@metamask/wallet-integrations` team ownership #36577

adonesky1 commented Oct 3, 2025 •

edited by cursor bot

Loading

metamaskbot commented Oct 3, 2025 •

edited

Loading