feat: Add shield subscription token approval confirmation #36576
+1,339
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (22 files, +1133 -12)
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
pedronfigueiredo
force-pushed
the
pnf/shield-confirmation
branch
from
bd84760 to
3951c1b
Compare
| const approvalData = generateERC20ApprovalData({ | ||
| spenderAddress, | ||
| amount: decimalToHex(selectedToken.approvalAmount.approveAmount), | ||
| }); |
There was a problem hiding this comment.
Bug: ERC20 Approval Defaults to Burn Address
The generateERC20ApprovalData function defaults its spenderAddress parameter to the burn address. If a valid spender isn't explicitly provided, the function generates an approval for the burn address, which could lead to tokens being permanently lost. The if (!spenderAddress) check doesn't prevent this, as the burn address is a truthy value.
Additional Locations (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Introduces a new
shieldSubscriptionApprovetransaction type with a dedicated confirmation UI, enables Shield crypto payments by creating ERC‑20 approve txs, and updates headers, i18n, utilities, tests, and@metamask/transaction-controller.TransactionType.shieldSubscriptionApproveto redesigned flow andInfomap, with new components (ShieldSubscriptionApproveInfo, loader, sections) and Jest snapshots.SHIELD_PLAN_ROUTE; title shows "Confirm membership"; hide advanced details toggle for this type.addTransaction), and navigate toCONFIRM_TRANSACTION_ROUTE.TOKEN_APPROVAL_FUNCTION_SIGNATUREandgenerateERC20ApprovalData; extend send utils/tests.@metamask/transaction-controllerto^60.6.0.Written by Cursor Bugbot for commit 3951c1b. This will update automatically on new commits. Configure here.