chore: Remove imagemin
#36563
Open
chore: Remove imagemin
#36563
+33
−1,161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metamaskbot update-policies |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
✨ Files requiring CODEOWNER review ✨🧩 @MetaMask/extension-devs (5 files, +5 -5)
📜 @MetaMask/policy-reviewers (5 files, +5 -5)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 🔗 @MetaMask/supply-chain (5 files, +5 -5)
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [c6a9ae5]
UI Startup Metrics (1233 ± 78 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| }); | ||
| } else { | ||
| optimizedBuffer = await sharp(filePath, { | ||
| const optimizedBuffer = await sharp(filePath, { |
There was a problem hiding this comment.
Bug: Image Optimization Issues with Sharp
The code now uses sharp for all image optimizations, including GIFs, but applies toFormat() options like compressionLevel, effort, quality, and lossless universally. These options are not valid for all formats, particularly GIFs, which can cause runtime errors, suboptimal compression, or loss of animation quality.
There was a problem hiding this comment.
Seems to have worked for optimizing spinner.gif 🤷♂️
davidmurdoch
approved these changes
Oct 3, 2025
Mrtenz
approved these changes
Oct 3, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 3, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Seemingly `sharp` is as efficient at optimizing GIFs as `imagemin` and doesn't have the same install-script problems on some systems that `gifsicle` brings. This PR proposes to use `sharp` for optimizing all images. Needs a sanity check. [](https://codespaces.new/MetaMask/metamask-extension/pull/36563?quickstart=1) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Replace `imagemin`/`gifsicle` with `sharp` for image optimization and remove related dependencies, updating configs and LavaMoat policies accordingly. > > - **Development tooling**: > - `development/optimize-media.mts`: Use `sharp` exclusively for all image formats; remove `imagemin`/`imagemin-gifsicle` logic and imports. > - **Dependencies**: > - Remove `imagemin`, `imagemin-gifsicle`, and their `@types` from `package.json`; prune related entries from `yarn.lock`. > - Update `.depcheckrc.yml` to drop `imagemin*` from ignored deps. > - **Security/Policies**: > - Update LavaMoat policies (`lavamoat/browserify/*/policy.json`, `lavamoat/build-system/policy.json`) to adjust package mappings (e.g., `is-plain-obj` path) and remove allowlist for `imagemin-gifsicle>gifsicle`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit c6a9ae5. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: MetaMask Bot <[email protected]>
](https://codespaces.new/MetaMask/metamask-extension/pull/36563?quickstart=1){kind=link}
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Seemingly
sharpis as efficient at optimizing GIFs asimageminand doesn't have the same install-script problems on some systems thatgifsiclebrings. This PR proposes to usesharpfor optimizing all images.Needs a sanity check.
Note
Replace
imagemin/gifsiclewithsharpfor image optimization and remove related dependencies, updating configs and LavaMoat policies accordingly.development/optimize-media.mts: Usesharpexclusively for all image formats; removeimagemin/imagemin-gifsiclelogic and imports.imagemin,imagemin-gifsicle, and their@typesfrompackage.json; prune related entries fromyarn.lock..depcheckrc.ymlto dropimagemin*from ignored deps.lavamoat/browserify/*/policy.json,lavamoat/build-system/policy.json) to adjust package mappings (e.g.,is-plain-objpath) and remove allowlist forimagemin-gifsicle>gifsicle.Written by Cursor Bugbot for commit c6a9ae5. This will update automatically on new commits. Configure here.